Move \Drupal\Tests\system\Functional\Module\ModuleTestBase::assertLogMessage to a trait

Thanks for splitting this off. Great novice task! I came here to help, but since you tagged it, better to leave this for others. 😅 At least now I'll see it when someone posts a patch or opens an MR, and hopefully whenever that happens I'll have a chance to review. 🤞

Hi @elber, thanks for moving this forward. From looking at your profile, you don't seem like a "novice". 😅 The intention of this tag is to identify issues that would be good for first-time contributors, not for folks like you and me to crank out easy fixes.

But, what's done is done, so now this needs review. Moving status to match reality.

Ok I'm sorry @dww, I won't make that mistake again

@elber: No worries! It's never a "mistake" to contribute to improving Drupal core. 😅. The tag should probably be called something more self-documenting like "Good for first contribution" or something, but that's kinda clumsy. Anyway, great that you're now aware of all this, and will save the "novice" issues for folks that are just getting started. Please spread the word to your co-workers, too. Obrigado!

Tchau,
-Derek

Move didn't seem to cause any issues so think this is good.

Looking at the proposed solution in the IS:

Move \Drupal\Tests\system\Functional\Module\ModuleTestBase::assertLogMessage to a trait

Check.

and use that trait in both ModuleTestBase

The trait is now used individually in DbLogTest and InstallUninstallTest instead of inheriting it from ModuleTestBase

and \Drupal\Tests\user\Functional\UserLoginHttpTest

The trait seems not to be used in that.

Search for any other tests that query the watchdog table and use the trait there too

Unsure if that happened?

Back to NW for the above.