πŸ‡§πŸ‡·Brazil @stephencamilo

curitiba
Account created on 27 April 2012, about 13 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

My main motivation to create this Feature Request is to change the amount of admin users per site.
Some projects need more than 3.

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

Thank you for your feedback and for highlighting the concerns with the patch. I’d like to address the issues and provide clarification:

  1. Apology for Naming Confusion:

    I sincerely apologize for the confusion in the first patch where I mistakenly mentioned entity_embed in the title while some changes were related to other dependencies. That was an oversight on my part, and I appreciate your patience in pointing it out.

  2. Regarding entity_embed Dependency:

    The updated patch ensures that drupal:entity_embed is properly declared in the entity_browser.info.yml file. This resolves the issue where entity_embed was previously only a Composer-level dependency, ensuring proper recognition within Drupal’s module system.

  3. Best Practices:

    Adding dependencies like entity_embed directly to the .info.yml file follows Drupal best practices, making it clear to site administrators and developers which modules are required at the Drupal level.

  4. Updated Patch:

    You can find the updated patch here: 3488251-update-core-version-requirement-1.patch β†’ .

  5. Next Steps:

    I propose testing the revised patch to confirm that the module installs without errors and that all required dependencies are recognized and functional. If you have any further feedback or suggestions, I’d be happy to address them.

Thank you again for your valuable insights and for helping improve the patch!

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

Tested the patch; it works as expected. Reviewed and tested by the community (RTBC)

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

Patch Name: 3488251-update-core-version-requirement.patch β†’

Summary of Changes:

  • Removed drupal/entityqueue from composer.json dependencies as it is better handled within the info.yml file.
  • Added drupal:entityqueue as a required dependency in entity_browser.info.yml to ensure proper module declaration.

Reason for Change:

This update aligns the Entity Browser module with best practices for dependency management in Drupal:

  1. Dependencies for Composer-managed installation are already declared via composer.json but should also exist in the .info.yml file to support Drupal's internal module system.
  2. It ensures compatibility with core versions ^10.2 and ^11 while cleaning up redundant or misplaced dependency declarations.

How to Test:

  1. Apply the patch.
  2. Verify that the module installs correctly with no missing dependency errors.
  3. Test usage of the Entity Browser module to ensure functionality remains intact.

Next Steps:

  • Review the patch.
  • If testing passes, mark the issue as "RTBC" (Reviewed and Tested by the Community).
πŸ‡§πŸ‡·Brazil stephencamilo curitiba

#2 patch still not being able to override gin/gin.

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

Hello @joachim,

Using 'a date' is suitable since the format can be applied to any date, not exclusively the current date.

I am planning to mark this issue as resolved. However, if you have an alternate input, please don't hesitate to share.

Thank you!

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

stephencamilo β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡·Brazil stephencamilo curitiba

Hi, I tried to reproduce the error by importing a .po file but got no error.
How can I test the issue and the fix?

Production build 0.71.5 2024