Remove Tour module from the Umami profile

So umami had css and a config file.

I deleted the CSS and moved the config file.
Also moved the one test function that was related to tour

Wonder if this needs sign off from Umami maintainer.

So moving the config is the issue. But not sure what to do for it.

Moving the config to optional feels appropriate to me

That’s what I did but the config has a dependency to demo_umami module. Should this config be deleted?

Went ahead and deleted the config. demo_umami isn't a module that I can tell. And the workflow would have to be

Someone installs umami
Download contrib tour
Not sure tour as a contrib really should maintain config for a demo profile.

Thanks for working on this. I've no issue with our Tour items being removed if Tour is being removed from core. But let's definitely not support Tour as a contrib module in our demo_umami profile - so let's remove _all_ of Tour from Umami and not have some of it supported via "optional" config.

@andypost think all the tour stuff has been removed

Instead of removal the Umami's tour could live in optional config of the module

core/profiles/demo_umami/config/install/tour.tour.umami-front.yml

So I tried that but I couldn't get around https://www.drupal.org/pift-ci-job/2722966 →

Reverted commit with removal - that's just a test which needs more fixes, so I excluded the profile and added to todo to existing issue 🐛 Core schema tests (DefaultConfigTest and TestViewsTest) can't reliably check contrib. Needs work

Works for me

Started CR here https://www.drupal.org/node/3377475 → (just copied Standard CR)

Added comment to the MR.

I don't think we actually need CR for this since this should not impact anyone. Umami is the demo experience and we are allowed to change that as we see fit.

removed test

Back to RTBC

Moving to needs work for the test restoration.

So instead of writing a new test module just used the toolbar module. Locally this passed.

Thanks @smustgrave, all threads answered, code changes look OK to me => RTBC

Committed 12be8e7 and pushed to 11.x. Thanks!

Does not backport cleanly to 10.1.x due to PerformanceTest, so let's just leave tour in Umami in 10.1.x, it doesn't harm anything.

Automatically closed - issue fixed for 2 weeks with no activity.

Published the change record.