- Issue created by @roberttabigue
- Status changed to Needs review
over 1 year ago 6:59am 24 July 2023 - last update
over 1 year ago 16 pass, 2 fail - 🇮🇳India mrinalini9 New Delhi
Added patch for the above phpcs issues, please review it.
Thanks!
The last submitted patch, 2: 3376155-2.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 7:44am 24 July 2023 phpcbf --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml /path/to/drupal/example_module
- 🇩🇪Germany Anybody Porta Westfalica
Please fix in combination with: 📌 Fix JS code style errors RTBC
Provide a MR with all fixes to review.
- Assigned to sourabhjain
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @sourabhjain opened merge request.
- last update
over 1 year ago 16 pass, 2 fail - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:36am 27 July 2023 - 🇮🇳India sourabhjain
@anybody created a PR including this issue changes https://www.drupal.org/project/spamspan/issues/3374657 📌 Fix JS code style errors RTBC
Please review. - Status changed to RTBC
over 1 year ago 4:30pm 27 July 2023 - 🇵🇭Philippines roberttabigue
Hi,
I applied the latest MR to the SpamSpan filter module against 3.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig spamspan/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!