Fix the issues reported by phpcs

Created on 7 July 2023, over 1 year ago
Updated 9 September 2024, 2 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/reading_rating/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 82 characters
29 | WARNING | Line exceeds 80 characters; contains 84 characters
32 | WARNING | Line exceeds 80 characters; contains 130 characters
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/reading_rating/css/reading-rating.css
----------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 15 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Multiple selectors should each be on a single line
19 | ERROR | [x] Multiple selectors should each be on a single line
30 | ERROR | [x] Multiple selectors should each be on a single line
35 | ERROR | [x] Multiple selectors should each be on a single line
35 | ERROR | [x] Multiple selectors should each be on a single line
35 | ERROR | [x] Multiple selectors should each be on a single line
38 | ERROR | [x] Multiple selectors should each be on a single line
41 | ERROR | [x] Multiple selectors should each be on a single line
46 | ERROR | [x] Multiple selectors should each be on a single line
49 | ERROR | [x] Multiple selectors should each be on a single line
57 | ERROR | [x] Multiple selectors should each be on a single line
63 | ERROR | [x] Multiple selectors should each be on a single line
71 | ERROR | [x] Multiple selectors should each be on a single line
74 | ERROR | [x] Multiple selectors should each be on a single line
78 | ERROR | [x] Multiple selectors should each be on a single line
83 | ERROR | [x] Multiple selectors should each be on a single line
88 | ERROR | [x] Multiple selectors should each be on a single line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/reading_rating/reading_rating.module
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------
43 | WARNING | [x] There must be no blank line following an inline comment
43 | WARNING | [ ] There must be no blank line following an inline comment
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/reading_rating/reading_rating.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

Time: 76ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig reading_rating/

Remaining tasks

Patch review

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Ashutosh Ahirwal India

    Provided patch applied cleanly but still throwing error.

    Used command
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/reading_rating

    Remaining issue
    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/reading_rating/js/text-statistics.js
    -------------------------------------------------------------------------------------------------------------
    FOUND 342 ERRORS AFFECTING 231 LINES
    -------------------------------------------------------------------------------------------------------------
    7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    8 | ERROR | [x] Whitespace found at end of line
    9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    10 | ERROR | [x] Whitespace found at end of line
    11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    12 | ERROR | [x] Whitespace found at end of line
    13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    13 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    14 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    16 | ERROR | [x] Whitespace found at end of line
    17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    18 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    18 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    19 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    19 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    20 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    21 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    22 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    23 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    24 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    25 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    26 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    26 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    27 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    28 | ERROR | [x] Whitespace found at end of line
    29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    34 | ERROR | [x] Whitespace found at end of line
    35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    38 | ERROR | [x] Whitespace found at end of line
    39 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    39 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    40 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    41 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    41 | ERROR | [x] Expected 1 space before "*"; 0 found
    41 | ERROR | [x] Expected 1 space after "*"; 0 found
    41 | ERROR | [x] Expected 1 space before "/"; 0 found
    41 | ERROR | [x] Expected 1 space after "/"; 0 found
    42 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    43 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    43 | ERROR | [x] Whitespace found at end of line
    44 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    44 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    45 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    46 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    46 | ERROR | [x] Expected 1 space before "*"; 0 found
    46 | ERROR | [x] Expected 1 space after "*"; 0 found
    46 | ERROR | [x] Expected 1 space before "/"; 0 found
    46 | ERROR | [x] Expected 1 space after "/"; 0 found
    47 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    48 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    48 | ERROR | [x] Whitespace found at end of line
    49 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    51 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    51 | ERROR | [x] Expected 1 space before "*"; 0 found
    51 | ERROR | [x] Expected 1 space after "*"; 0 found
    51 | ERROR | [x] Expected 1 space before "/"; 0 found
    51 | ERROR | [x] Expected 1 space after "/"; 0 found
    52 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    53 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    53 | ERROR | [x] Whitespace found at end of line
    54 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    54 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    55 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    56 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    56 | ERROR | [x] Expected 1 space after "*"; 0 found
    56 | ERROR | [x] Expected 1 space before "/"; 0 found
    56 | ERROR | [x] Expected 1 space after "/"; 0 found
    57 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    58 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    58 | ERROR | [x] Whitespace found at end of line
    59 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    59 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    60 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    61 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    61 | ERROR | [x] Expected 1 space before "*"; 0 found
    61 | ERROR | [x] Expected 1 space after "*"; 0 found
    61 | ERROR | [x] Expected 1 space before "/"; 0 found
    61 | ERROR | [x] Expected 1 space after "/"; 0 found
    62 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    63 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    63 | ERROR | [x] Whitespace found at end of line
    64 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    64 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    65 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    66 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    66 | ERROR | [x] Expected 1 space before "*"; 0 found
    66 | ERROR | [x] Expected 1 space after "*"; 0 found
    66 | ERROR | [x] Expected 1 space before "/"; 0 found
    66 | ERROR | [x] Expected 1 space after "/"; 0 found
    67 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    69 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    69 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    70 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    71 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    72 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    73 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    73 | ERROR | [x] Whitespace found at end of line
    74 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    74 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    75 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    76 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    77 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    78 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    79 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    79 | ERROR | [x] Whitespace found at end of line
    80 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    80 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    82 | ERROR | [x] Whitespace found at end of line
    83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    86 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    86 | ERROR | [x] Whitespace found at end of line
    87 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    87 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    88 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    89 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    90 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    91 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    91 | ERROR | [x] Whitespace found at end of line
    92 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    92 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    93 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    94 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    95 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    96 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    96 | ERROR | [x] Whitespace found at end of line
    97 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    97 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    98 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    99 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    100 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    100 | ERROR | [x] Whitespace found at end of line
    101 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    101 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    102 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    103 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    104 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    104 | ERROR | [x] Whitespace found at end of line
    105 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    106 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    107 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    108 | ERROR | [x] Whitespace found at end of line
    109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    109 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    110 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    111 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    112 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    112 | ERROR | [x] Whitespace found at end of line
    113 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    114 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    114 | ERROR | [x] Whitespace found at end of line
    115 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    115 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    116 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    116 | ERROR | [x] Whitespace found at end of line
    117 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    118 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    119 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    120 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    120 | ERROR | [x] Inline control structures are not allowed
    121 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    122 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    123 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    123 | ERROR | [x] Whitespace found at end of line
    124 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    125 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    126 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    126 | ERROR | [x] Whitespace found at end of line
    127 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    127 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    129 | ERROR | [x] Whitespace found at end of line
    130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    131 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    132 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    132 | ERROR | [x] Whitespace found at end of line
    133 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    133 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    134 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    137 | ERROR | [x] Whitespace found at end of line
    138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    139 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    140 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    140 | ERROR | [x] Whitespace found at end of line
    141 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    142 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    143 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    144 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    144 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    145 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    145 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    146 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    146 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
    147 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    148 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    148 | ERROR | [x] Whitespace found at end of line
    149 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    150 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    150 | ERROR | [x] Inline control structures are not allowed
    151 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    151 | ERROR | [x] Whitespace found at end of line
    152 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    153 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    154 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    155 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    156 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    157 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    158 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    159 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    160 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    161 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    162 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    163 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    164 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    165 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    166 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    167 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    168 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    169 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    169 | ERROR | [x] Expected 1 space after "/"; 0 found
    169 | ERROR | [x] Expected 1 space before "/"; 0 found
    170 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    171 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    171 | ERROR | [x] Whitespace found at end of line
    172 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    173 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    174 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    175 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    176 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    177 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    178 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    179 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    180 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    181 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    182 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    183 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    184 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    185 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    186 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    187 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    188 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    189 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    190 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    191 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    192 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    192 | ERROR | [x] Whitespace found at end of line
    193 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    194 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    195 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    196 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    197 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    198 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    199 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    200 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    201 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    202 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    203 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    203 | ERROR | [x] Whitespace found at end of line
    204 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    205 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    205 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    206 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    207 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    208 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    209 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    210 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    211 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    211 | ERROR | [x] Whitespace found at end of line
    212 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    213 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    214 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    214 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    215 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    216 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    217 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    218 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    218 | ERROR | [x] Whitespace found at end of line
    219 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    220 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    221 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    221 | ERROR | [x] Whitespace found at end of line
    222 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    223 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    223 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    224 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    224 | ERROR | [x] Inline control structures are not allowed
    225 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    226 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    226 | ERROR | [x] Whitespace found at end of line
    227 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    227 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    228 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    228 | ERROR | [x] Inline control structures are not allowed
    229 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    230 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    230 | ERROR | [x] Whitespace found at end of line
    231 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    232 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    233 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    233 | ERROR | [x] Whitespace found at end of line
    234 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    235 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    236 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    237 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    237 | ERROR | [x] Whitespace found at end of line
    238 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
    238 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    -------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 342 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/reading_rating/js/reading-rating.js
    ------------------------------------------------------------------------------------------------------------
    FOUND 176 ERRORS AFFECTING 27 LINES
    ------------------------------------------------------------------------------------------------------------
    13 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    19 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    20 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    36 | ERROR | [x] Expected 1 space after "<"; 0 found
    36 | ERROR | [x] Expected 1 space before "="; 0 found
    36 | ERROR | [x] Expected 1 space after "="; 0 found
    36 | ERROR | [x] Expected 1 space before ">"; 0 found
    37 | ERROR | [x] Expected 1 space after "<"; 0 found
    37 | ERROR | [x] Expected 1 space before "="; 0 found
    37 | ERROR | [x] Expected 1 space after "="; 0 found
    37 | ERROR | [x] Expected 1 space before ">"; 0 found
    38 | ERROR | [x] Expected 1 space after "<"; 0 found
    38 | ERROR | [x] Expected 1 space before "="; 0 found
    38 | ERROR | [x] Expected 1 space after "="; 0 found
    38 | ERROR | [x] Expected 1 space before ">"; 0 found
    38 | ERROR | [x] Expected 1 space after ">"; 0 found
    38 | ERROR | [x] Expected 1 space before "<"; 0 found
    38 | ERROR | [x] Expected 1 space after "<"; 0 found
    38 | ERROR | [x] Expected 1 space before "/"; 0 found
    38 | ERROR | [x] Expected 1 space after "/"; 0 found
    38 | ERROR | [x] Expected 1 space before ">"; 0 found
    39 | ERROR | [x] Expected 1 space after "<"; 0 found
    39 | ERROR | [x] Expected 1 space before "="; 0 found
    39 | ERROR | [x] Expected 1 space after "="; 0 found
    39 | ERROR | [x] Expected 1 space before ">"; 0 found
    40 | ERROR | [x] Expected 1 space after "<"; 0 found
    40 | ERROR | [x] Expected 1 space before "="; 0 found
    40 | ERROR | [x] Expected 1 space after "="; 0 found
    40 | ERROR | [x] Expected 1 space before ">"; 0 found
    41 | ERROR | [x] Expected 1 space after "<"; 0 found
    41 | ERROR | [x] Expected 1 space before "-"; 0 found
    41 | ERROR | [x] Expected 1 space after "-"; 0 found
    41 | ERROR | [x] Expected 1 space before "-"; 0 found
    41 | ERROR | [x] Expected 1 space after "-"; 0 found
    41 | ERROR | [x] Expected 1 space before "="; 0 found
    41 | ERROR | [x] Expected 1 space after "="; 0 found
    41 | ERROR | [x] Expected 1 space before "="; 0 found
    41 | ERROR | [x] Expected 1 space after "="; 0 found
    41 | ERROR | [x] Expected 1 space before "-"; 0 found
    41 | ERROR | [x] Expected 1 space after "-"; 0 found
    41 | ERROR | [x] Expected 1 space before "="; 0 found
    41 | ERROR | [x] Expected 1 space after "="; 0 found
    41 | ERROR | [x] Expected 1 space before ">"; 0 found
    41 | ERROR | [x] Expected 1 space after ">"; 0 found
    41 | ERROR | [x] Expected 1 space before "<"; 0 found
    41 | ERROR | [x] Expected 1 space after "<"; 0 found
    41 | ERROR | [x] Expected 1 space before "/"; 0 found
    41 | ERROR | [x] Expected 1 space after "/"; 0 found
    41 | ERROR | [x] Expected 1 space before ">"; 0 found
    42 | ERROR | [x] Expected 1 space after "<"; 0 found
    42 | ERROR | [x] Expected 1 space before "-"; 0 found
    42 | ERROR | [x] Expected 1 space after "-"; 0 found
    42 | ERROR | [x] Expected 1 space before "-"; 0 found
    42 | ERROR | [x] Expected 1 space after "-"; 0 found
    42 | ERROR | [x] Expected 1 space before "="; 0 found
    42 | ERROR | [x] Expected 1 space after "="; 0 found
    42 | ERROR | [x] Expected 1 space before "="; 0 found
    42 | ERROR | [x] Expected 1 space after "="; 0 found
    42 | ERROR | [x] Expected 1 space before "-"; 0 found
    42 | ERROR | [x] Expected 1 space after "-"; 0 found
    42 | ERROR | [x] Expected 1 space before "="; 0 found
    42 | ERROR | [x] Expected 1 space after "="; 0 found
    42 | ERROR | [x] Expected 1 space before ">"; 0 found
    42 | ERROR | [x] Expected 1 space after ">"; 0 found
    42 | ERROR | [x] Expected 1 space before "<"; 0 found
    42 | ERROR | [x] Expected 1 space after "<"; 0 found
    42 | ERROR | [x] Expected 1 space before "/"; 0 found
    42 | ERROR | [x] Expected 1 space after "/"; 0 found
    42 | ERROR | [x] Expected 1 space before ">"; 0 found
    43 | ERROR | [x] Expected 1 space after "<"; 0 found
    43 | ERROR | [x] Expected 1 space before "-"; 0 found
    43 | ERROR | [x] Expected 1 space after "-"; 0 found
    43 | ERROR | [x] Expected 1 space before "-"; 0 found
    43 | ERROR | [x] Expected 1 space after "-"; 0 found
    43 | ERROR | [x] Expected 1 space before "="; 0 found
    43 | ERROR | [x] Expected 1 space after "="; 0 found
    43 | ERROR | [x] Expected 1 space before "="; 0 found
    43 | ERROR | [x] Expected 1 space after "="; 0 found
    43 | ERROR | [x] Expected 1 space before "-"; 0 found
    43 | ERROR | [x] Expected 1 space after "-"; 0 found
    43 | ERROR | [x] Expected 1 space before "="; 0 found
    43 | ERROR | [x] Expected 1 space after "="; 0 found
    43 | ERROR | [x] Expected 1 space before ">"; 0 found
    43 | ERROR | [x] Expected 1 space after ">"; 0 found
    43 | ERROR | [x] Expected 1 space before "<"; 0 found
    43 | ERROR | [x] Expected 1 space after "<"; 0 found
    43 | ERROR | [x] Expected 1 space before "/"; 0 found
    43 | ERROR | [x] Expected 1 space after "/"; 0 found
    43 | ERROR | [x] Expected 1 space before ">"; 0 found
    44 | ERROR | [x] Expected 1 space after "<"; 0 found
    44 | ERROR | [x] Expected 1 space before "-"; 0 found
    44 | ERROR | [x] Expected 1 space after "-"; 0 found
    44 | ERROR | [x] Expected 1 space before "-"; 0 found
    44 | ERROR | [x] Expected 1 space after "-"; 0 found
    44 | ERROR | [x] Expected 1 space before "="; 0 found
    44 | ERROR | [x] Expected 1 space after "="; 0 found
    44 | ERROR | [x] Expected 1 space before "="; 0 found
    44 | ERROR | [x] Expected 1 space after "="; 0 found
    44 | ERROR | [x] Expected 1 space before "-"; 0 found
    44 | ERROR | [x] Expected 1 space after "-"; 0 found
    44 | ERROR | [x] Expected 1 space before "="; 0 found
    44 | ERROR | [x] Expected 1 space after "="; 0 found
    44 | ERROR | [x] Expected 1 space before ">"; 0 found
    44 | ERROR | [x] Expected 1 space after ">"; 0 found
    44 | ERROR | [x] Expected 1 space before "<"; 0 found
    44 | ERROR | [x] Expected 1 space after "<"; 0 found
    44 | ERROR | [x] Expected 1 space before "/"; 0 found
    44 | ERROR | [x] Expected 1 space after "/"; 0 found
    44 | ERROR | [x] Expected 1 space before ">"; 0 found
    45 | ERROR | [x] Expected 1 space after "<"; 0 found
    45 | ERROR | [x] Expected 1 space before "/"; 0 found
    45 | ERROR | [x] Expected 1 space after "/"; 0 found
    45 | ERROR | [x] Expected 1 space before ">"; 0 found
    46 | ERROR | [x] Expected 1 space after "<"; 0 found
    46 | ERROR | [x] Expected 1 space before "/"; 0 found
    46 | ERROR | [x] Expected 1 space after "/"; 0 found
    46 | ERROR | [x] Expected 1 space before ">"; 0 found
    47 | ERROR | [x] Expected 1 space after "<"; 0 found
    47 | ERROR | [x] Expected 1 space before "="; 0 found
    47 | ERROR | [x] Expected 1 space after "="; 0 found
    47 | ERROR | [x] Expected 1 space before ">"; 0 found
    47 | ERROR | [x] Expected 1 space after ">"; 0 found
    47 | ERROR | [x] Expected 1 space after "<"; 0 found
    47 | ERROR | [x] Expected 1 space before "="; 0 found
    47 | ERROR | [x] Expected 1 space after "="; 0 found
    47 | ERROR | [x] Expected 1 space before "="; 0 found
    47 | ERROR | [x] Expected 1 space after "="; 0 found
    47 | ERROR | [x] Expected 1 space before ">"; 0 found
    47 | ERROR | [x] Expected 1 space after ">"; 0 found
    47 | ERROR | [x] Expected 1 space before "<"; 0 found
    47 | ERROR | [x] Expected 1 space after "<"; 0 found
    47 | ERROR | [x] Expected 1 space before "/"; 0 found
    47 | ERROR | [x] Expected 1 space after "/"; 0 found
    47 | ERROR | [x] Expected 1 space before ">"; 0 found
    47 | ERROR | [x] Expected 1 space after ">"; 0 found
    47 | ERROR | [x] Expected 1 space before "<"; 0 found
    47 | ERROR | [x] Expected 1 space after "<"; 0 found
    47 | ERROR | [x] Expected 1 space before "/"; 0 found
    47 | ERROR | [x] Expected 1 space after "/"; 0 found
    47 | ERROR | [x] Expected 1 space before ">"; 0 found
    48 | ERROR | [x] Expected 1 space after "<"; 0 found
    48 | ERROR | [x] Expected 1 space before "/"; 0 found
    48 | ERROR | [x] Expected 1 space after "/"; 0 found
    48 | ERROR | [x] Expected 1 space before ">"; 0 found
    48 | ERROR | [x] Expected 1 space after ">"; 0 found
    66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    72 | ERROR | [x] Expected 1 space before "-"; 0 found
    72 | ERROR | [x] Expected 1 space after "-"; 0 found
    72 | ERROR | [x] Expected 1 space before "-"; 0 found
    72 | ERROR | [x] Expected 1 space after "-"; 0 found
    72 | ERROR | [x] Expected 1 space before "="; 0 found
    72 | ERROR | [x] Expected 1 space after "="; 0 found
    78 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    80 | ERROR | [x] Expected 1 space before "-"; 0 found
    80 | ERROR | [x] Expected 1 space after "-"; 0 found
    80 | ERROR | [x] Expected 1 space before "-"; 0 found
    80 | ERROR | [x] Expected 1 space after "-"; 0 found
    80 | ERROR | [x] Expected 1 space before "="; 0 found
    80 | ERROR | [x] Expected 1 space after "="; 0 found
    84 | ERROR | [x] Expected 1 space before "-"; 0 found
    84 | ERROR | [x] Expected 1 space after "-"; 0 found
    84 | ERROR | [x] Expected 1 space before "-"; 0 found
    84 | ERROR | [x] Expected 1 space after "-"; 0 found
    84 | ERROR | [x] Expected 1 space before "="; 0 found
    84 | ERROR | [x] Expected 1 space after "="; 0 found
    88 | ERROR | [x] Expected 1 space before "-"; 0 found
    88 | ERROR | [x] Expected 1 space after "-"; 0 found
    88 | ERROR | [x] Expected 1 space before "-"; 0 found
    88 | ERROR | [x] Expected 1 space after "-"; 0 found
    88 | ERROR | [x] Expected 1 space before "="; 0 found
    88 | ERROR | [x] Expected 1 space after "="; 0 found
    98 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    99 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    101 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    111 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    112 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    ------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 176 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------

    Time: 150ms; Memory: 14MB

    Providing updated patch with fixes

  • bindu r โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States codechefmarc

    Dev version has been updated with the phpcs changes. Thanks for reporting! I'll be making some further changes to the dev version before merging in.

  • Status changed to Needs review 11 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States codechefmarc
  • Status changed to Needs work 6 months ago
  • Hi ser @codechefmarc,

    Dev version still have phpcs warnings, please see below.

    reading_rating git:(1.0.x) cd ..
    โžœ  contrib git:(main) โœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig reading_rating
    
    FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/reading_rating/README.md
    -------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    -------------------------------------------------------------------------------------------------
     23 | WARNING | Line exceeds 80 characters; contains 82 characters
     29 | WARNING | Line exceeds 80 characters; contains 84 characters
     35 | WARNING | Line exceeds 80 characters; contains 89 characters
     38 | WARNING | Line exceeds 80 characters; contains 130 characters
    -------------------------------------------------------------------------------------------------
    
    Time: 200ms; Memory: 10MB

    Thanks,
    Jake

  • First commit to issue fork.
  • Merge request !3Main โ†’ (Open) created by paraderojether
  • Assigned to priyanka_chauhan31
  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia priyanka_chauhan31 Noida

    Hi, please review.

  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines clarkssquared

    Hi priyanka,

    I applied your patch #10 and I confirmed that it fixes all the PHPCS issues:

    โžœ  reading_rating git:(1.0.x) curl https://www.drupal.org/files/issues/2024-08-05/coding_standard_fix-3359957-10.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  1706  100  1706    0     0   3405      0 --:--:-- --:--:-- --:--:--  3453
    patching file README.md
    โžœ  reading_rating git:(1.0.x) โœ— ..
    โžœ  contrib git:(main) โœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml reading_rating 
    โžœ  contrib git:(main) โœ— 

    however, can you add this into the existing MR for maintainer's conevenience? I will tranistion this to needs work for that. Thanks.

  • Status changed to Needs work 3 months ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines clarkssquared
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States codechefmarc

    Thank you, @priyanka_chauhan31 for the patch. I've applied to dev version and will be part of the latest release coming out soon.

  • Status changed to Fixed 2 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States codechefmarc

    Fixed in 1.1.0.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024