- Issue created by @Hamid.ali
- 🇮🇳India Hamid.ali
Attaching the patch for the issue and working on the tests
- last update
11 months ago Custom Commands Failed - 🇮🇳India Hamid.ali
Adding updated patch and checking for custom commands to pass
- 🇮🇳India Hamid.ali
Adding updated patch and interdiff also checking for custom commands to pass
- last update
11 months ago Custom Commands Failed - last update
11 months ago Custom Commands Failed - 🇮🇳India Hamid.ali
Fixed custom commands error and attaching the updated patch and interdiff and also checking for custom commands to pass
- last update
11 months ago 29,443 pass - Status changed to Needs review
11 months ago 12:51pm 5 July 2023 - 🇮🇳India Hamid.ali
All the custom commands are passing with the latest patch.
- 🇺🇸United States smustgrave
Think this is a non problem. But will let maintainer decide.
Instead of going through the figmas there are 16,000 issues on d.o would start there is you're looking to contribute.
- 🇮🇳India Hamid.ali
@smustgrave Logo is completely different so adding the right one is important to keep the theme updated with the figma I believe also if going through the figma design is against the rules let me know as I am new to the drupal community and felt it important on my part to contribute to the issues which are not there in the existing queue but important to address.
- Status changed to Needs work
10 months ago 7:12am 8 August 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
10 months ago 7:15am 8 August 2023 - 🇮🇳India djsagar
@Hamid.ali Patch applied successfully and that it matches the design in Figma! Matching the implementation with the design is an important step in ensuring a consistent and visually appealing user experience.
RTBC +1
Regard!
- Status changed to RTBC
9 months ago 10:03am 23 August 2023 - last update
9 months ago 29,469 pass - Status changed to Needs review
9 months ago 12:23pm 23 August 2023 - last update
9 months ago 30,056 pass - Status changed to Postponed: needs info
9 months ago 1:21am 5 September 2023 - 🇺🇸United States smustgrave
I actually believe this can be closed won’t fix.
It’s been pointed out that design decisions were made before D8 launch and haven’t been backported to figma.
But the logo currently matches Drupal.org logo and this ticket seems to change it back to the old logo.
Anyone agree?
- 🇺🇸United States Chris Matthews
Agreed with #16 🐛 Olivero: Fix powered-by block Closed: won't fix
- Status changed to Closed: won't fix
9 months ago 1:16pm 5 September 2023