Clicking X in input type search on module page on chrome does nothing

Not setting NR as the patch works only in Chrome. We probably need to change the event type to input to get it working correctly in all browsers.

I applied patch #3 and it's working as accepted so we can move this as RTBC.
For reference, sharing video.

Thanks!

Here is feedback from duplicated issue 🐛 Clicking X in input type search on module page on chrome does nothing Closed: duplicate

Also here is a list of people who worked on duplicated issue (to include their names in commit):
- narendrar
- marcoliver
- bnjmnm

Updating title of the issue.
Double checked if `input` event is enough instead of keyup - seems it's working on all browsers. `keyup` event is not required anymore. But it needs tests in all browsers once again since #4 🐛 Clicking X in input type search on module page on chrome does nothing Fixed tests are not not really obvious (not clear which browser was tests, and if only one browser or not). So need to tests typing/clearing results in all browsers now

Just to repeat my last comment from the duplicate issue. bnjmnm had pointed to the input event as a good alternative (which I would agree to in principle), were it not for browser compatibility.

https://www.drupal.org/docs/system-requirements/browser-requirements → lists Opera mini as a supported browser for Core.

https://caniuse.com/input-event states that Opera mini does not support the input event.

So moving to the input event would break compatibility with that browser.

My proposed solution → was to instead add a click event listener (which is of course not ideal, but should work across the board).

The last submitted patch, 2: module-filter-3371844-2.patch, failed testing. View results →

The Can I Use Opera Mini section is generated using the "Extreme data saving" mode which is not supported by Drupal: https://www.drupal.org/node/3217671 → .

Ah, thanks for the info, lauriii!

smustgrave → credited bnjmnm → .

smustgrave → credited narendraR → .

Added credit from closed duplicate issue

Moving to NW for the tests

Sorry if there was any confusion in the other issue that may have slowed things down. I did want to point out that browser compatibility was likely why the keyup event was chosen when this was initially implemented many years ago, but support for input has since caught up. Glad to see core catching up too 😎

Tested manually in Chrome, Firefox and Safari and the functionality is working as expected.

One thing to add, similar problem is fixed in https://www.drupal.org/project/drupal/issues/229193 ✨ Incremental filter for permissions page Fixed with a different way. We can update core/modules/user/user.permissions.js code to use the solution mentioned here in this issue.

Marking it as NR as manual testing is already done in #15. Not sure if anything is missing here.

Not sure if this needs a test case but manual testing appears complete per #16.

Going to mark

The last submitted patch, 2: module-filter-3371844-2.patch, failed testing. View results →

The last submitted patch, 2: module-filter-3371844-2.patch, failed testing. View results →

The last submitted patch, 3: 3371844-3.patch, failed testing. View results →

Going to remark as failure appeared random. @yash.rode is there a change in #22 that's missing? #3 still applies cleanly to 11.x.

Committed c9ced83 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.