- Issue created by @mondrake
- last update
about 1 year ago Custom Commands Failed - @mondrake opened merge request.
- last update
about 1 year ago 29,573 pass - last update
about 1 year ago 29,571 pass, 1 fail - Assigned to mondrake
- last update
about 1 year ago 29,797 pass, 1 fail - last update
about 1 year ago 29,803 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:53am 3 July 2023 - 🇮🇹Italy mondrake 🇮🇹
IMHO we should be able to instantiate
Time
also with no request stack. Yes the having the request stack available is in the normal path with container injection, but you may want to have aTime
instance available also in early bootstrap containers and/or unit tests whenrequest_path
service is not a thing. - Status changed to RTBC
about 1 year ago 4:01pm 3 July 2023 - 🇳🇱Netherlands Spokje
Dropped some minor, non-RTBC-blocking nits in the MR.
Not claiming to fully understand this, but the parts I do get make sense, moving to RTBC to lure core-committer eyes 'n brains to it.
- 🇮🇹Italy mondrake 🇮🇹
@Spokje if you want, share your doubts and I will certainly try to address them - and if I can't then at least we make them shout :)
- last update
about 1 year ago 29,803 pass - 🇳🇱Netherlands Spokje
No doubts, cause for the issue seems legit, also because many moons ago I worked on a related issue where tests went wrong on timing of Time.
Also can't come up with a better or even other way to do this, so I'm getting the popcorn and await the shouting ;)
- last update
about 1 year ago Build Successful - last update
about 1 year ago 29,804 pass - last update
about 1 year ago 29,804 pass - last update
about 1 year ago 29,810 pass - last update
about 1 year ago 29,814 pass - last update
about 1 year ago 29,817 pass - last update
about 1 year ago 29,817 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Waiting for branch to pass - last update
about 1 year ago 29,875 pass - last update
about 1 year ago 29,879 pass - last update
about 1 year ago 29,883 pass - last update
about 1 year ago 29,887 pass - last update
about 1 year ago 29,910 pass - last update
about 1 year ago 29,913 pass - First commit to issue fork.
- last update
about 1 year ago 29,914 pass - last update
about 1 year ago 29,948 pass - last update
about 1 year ago 29,955 pass - last update
about 1 year ago 29,955 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,961 pass - last update
about 1 year ago 30,046 pass - last update
about 1 year ago 30,051 pass - last update
about 1 year ago 30,058 pass - last update
about 1 year ago 30,034 pass, 2 fail - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → .
After reading the IS and comments I don't see anything left to do. I did a scan of the comments in the patch and they all made sense.
Leaving at RTBC.
- last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,062 pass - last update
about 1 year ago 30,064 pass - last update
about 1 year ago 30,131 pass, 2 fail - last update
about 1 year ago 30,137 pass - last update
about 1 year ago 30,138 pass - last update
about 1 year ago 30,138 pass - last update
12 months ago 30,148 pass - last update
12 months ago 30,148 pass - last update
12 months ago 30,150 pass -
longwave →
committed 5427d50c on 11.x
Issue #3371840 by mondrake, Spokje: Time::getRequestTime is not...
-
longwave →
committed 5427d50c on 11.x
- Status changed to Fixed
12 months ago 9:29pm 12 September 2023 - 🇬🇧United Kingdom longwave UK
This makes sense to me and I see no better way of doing it. It adds no new API, only changing the fallback return value in an edge case, which will help in a small number of tests.
Also not a fan of
sleep()
in tests but as we are testing time itself here I also see no better way of doing that!Not backported to 10.1.x as this is a minor behaviour change and the REQUEST_TIME changes likely won't need to be backported either.
Committed 5427d50 and pushed to 11.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.