Time::getRequestTime is not immutable when there is no request

On this.

IMHO we should be able to instantiate Time also with no request stack. Yes the having the request stack available is in the normal path with container injection, but you may want to have a Time instance available also in early bootstrap containers and/or unit tests when request_path service is not a thing.

Dropped some minor, non-RTBC-blocking nits in the MR.

Not claiming to fully understand this, but the parts I do get make sense, moving to RTBC to lure core-committer eyes 'n brains to it.

@Spokje if you want, share your doubts and I will certainly try to address them - and if I can't then at least we make them shout :)

No doubts, cause for the issue seems legit, also because many moons ago I worked on a related issue where tests went wrong on timing of Time.

Also can't come up with a better or even other way to do this, so I'm getting the popcorn and await the shouting ;)

I'm triaging RTBC issues → .

After reading the IS and comments I don't see anything left to do. I did a scan of the comments in the patch and they all made sense.

Leaving at RTBC.

This makes sense to me and I see no better way of doing it. It adds no new API, only changing the fallback return value in an edge case, which will help in a small number of tests.

Also not a fan of sleep() in tests but as we are testing time itself here I also see no better way of doing that!

Not backported to 10.1.x as this is a minor behaviour change and the REQUEST_TIME changes likely won't need to be backported either.

Committed 5427d50 and pushed to 11.x. Thanks!

mondrake → closed merge request !4303

Automatically closed - issue fixed for 2 weeks with no activity.