NodeCompleteNodeTranslationLookup should return NULL for non translated lookups

The test is added to the existing MigrateUrlAliasTest, reworking it a bit so that the save checks are made with using the node_translation migration and the node_complete migration.

@quietone what's a good way to test this one?

I see that the patch has an extra test, left over from development. I have fixed that and am uploading a fail patch as well. This is close to starting over so I am not making an interdiff.

As for testing, you could manually following the steps taken in the Kernel tests to generate the d6_node and d6_node_complete tables. By examining them you should be able to confirm that when 3 values are passed to the process plugin it will return the same 2 values that a lookup on d6_node would.

The last submitted patch, 4: 3371828-4-fail.patch, failed testing. View results →

This is one I wasn't 100% sure how to test but will lean on the test-only patch. The order of the migrations makes sense and clearly shows the failure. So in effort to keep things moving going to mark this but please don't credit me for anything.

Retesting. The test showed 'build successful' and there were no errors that I saw when looking at the test results.

The last submitted patch, 4: 3371828-4.patch, failed testing. View results →

The failure is an unrelated test. Retesting

1) Drupal\Tests\menu_ui\Functional\MenuUiTest::testMenuAdministration
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/subdirectory/admin/structure/menu/manage/v3dok6md'
+'/subdirectory/admin/structure/menu/manage/v22dzocg'

The last submitted patch, 4: 3371828-4.patch, failed testing. View results →

Tests are passing again, restoring RTBC.

The last submitted patch, 4: 3371828-4.patch, failed testing. View results →

Hmm, 930 tests failures with this error message.

1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
TypeError: Drupal\Core\Database\Transaction\TransactionManagerBase::removeStackItem(): Argument #1 ($id) must be of type string, int given, called in /var/www/html/core/lib/Drupal/Core/Database/Transaction/TransactionManagerBase.php on line 228

Since most are not related to migrate, I am retesting.

Saw that today but in night watch..

It was because this broke HEAD, 🐛 Strengthen TransactionManager Needs work .

Tests are passing, restoring RTBC.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Convert patch 4 to an MR and hide patches. The patch applied without rejects and tests are passing so I am restoring RTBC.

Backported to 10.2.x as a low risk bug fix.

Committed and pushed c6eb905222 to 11.x and 4bab32680e to 10.2.x. Thanks!

quietone → closed merge request !5347

Automatically closed - issue fixed for 2 weeks with no activity.