Migrate UI upgrade tests should provide the complete log

Just updating the patch.

A bit of a typo.

@sonam_sharma, credit has been removed per How is credit granted for Drupal core issues →

This patch removes the changes to drupalci and to core/modules/migrate_drupal/src/Plugin/migrate/process/NodeCompleteNodeTranslationLookup.php. The latter should be in a separate issue.

The last submitted patch, 106: 3082211-106.patch, failed testing. View results →

Back to needs review.

Want to request an uncheck all button. Since the fix has moved to MR5272 hiding the patches for clarity.

Rebased MR5272 to run test-only feature

1) Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test::testUpgradeAndIncremental
Error: Call to undefined method Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test::outputLogs()
/builds/issue/drupal-3082211/core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6Test.php:211
/builds/issue/drupal-3082211/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 1, Assertions: 4364, Errors: 1.
Unsilenced deprecation notices (3)
  1x: Creation of dynamic property Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test::$outputLogs is deprecated
    1x in Upgrade6Test::testUpgradeAndIncremental from Drupal\Tests\migrate_drupal_ui\Functional\d6
  1x: Creation of dynamic property Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test::$migratedAdminUserName is deprecated
    1x in Upgrade6Test::testUpgradeAndIncremental from Drupal\Tests\migrate_drupal_ui\Functional\d6
  1x: Creation of dynamic property Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test::$expectedLoggedErrors is deprecated
    1x in Upgrade6Test::testUpgradeAndIncremental from Drupal\Tests\migrate_drupal_ui\Functional\d6
Uploading artifacts for failed job

The change itself seems simple enough.

Added some questions to the MR.

I've answered the queries and adjusted the error message count.

Left some small nitpicky stuff, leaving in review for additional eyes.

Seems nitpicky stuff was addressed. Since this was close before believe it's fine to mark now.

Needs rebasing against 11.x, there are lots of unrelated changes in the MR.

@longwave, sorry about that. I don't know how that happened, but it is fixed now. I am restoring RTBC because there were no conflicts when rebasing.

Confirmed via GitLab CI that the tests pass on SQLite now. However, decided not to backport as this is a minimal improvement and seems slightly fragile given the hardcoded log counts.

Committed a904645 and pushed to 11.x. Thanks!

longwave → closed merge request !5272

Automatically closed - issue fixed for 2 weeks with no activity.