- Issue created by @kiwad
- First commit to issue fork.
- last update
over 1 year ago 38 pass - Status changed to Needs review
over 1 year ago 6:34pm 14 June 2023 - π¨π¦Canada kiwad
That was fast :)
I've tested with normal test card and insufficent funds test card it removes
User warning : The following theme is missing from the file system: classy dans Drupal\Core\Extension\ExtensionPathResolver->getPathname()
and
Deprecated function : dirname(): Passing null to parameter #1 ($path) of type string is deprecated dans Drupal\Core\Extension\ExtensionPathResolver->getPath()
in /checkout/{id}/review and checkout/{id}/order_information
- Status changed to Needs work
over 1 year ago 5:20am 18 June 2023 - Status changed to RTBC
over 1 year ago 5:52pm 18 June 2023 - π«π·France Grimreaper France π«π·
Hi,
Thanks for the MR, I encountered the same issue and it fixed it.
- last update
over 1 year ago 38 pass - π«π·France Grimreaper France π«π·
Uploading patch for easier Composer usage.
- πΊπΈUnited States rszrama
I've noticed this issue during testing in a clean Commerce Kickstart 3.x instance as well.
- πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
@rszrama
I also noticed that we lost styles for error messages on D10. See the attached screenshot for more information.
So it seems we need to create our own styles if we don't want to have dependencies on other themes or modules.
Also, I see a dependency on "classy/messages" in the commerce_braintree module (we need to create an issue there), so maybe it makes sense to create global styles? - Status changed to Needs work
about 1 year ago 5:19pm 5 September 2023 - πΊπΈUnited States rszrama
Ok, since this change simply removes styling that should be there, it's not an appropriate fix. Instead, we've created an issue against Commerce Core for defining a replacement library that this module can then be updated to use: π Provide a basic replacement for Classy's messages library in the Payment module RTBC
- Merge request !60Resolve #3366832 "Add dependency payment messages" β (Merged) created by Unnamed author
- last update
about 1 year ago 38 pass - Status changed to Needs review
about 1 year ago 2:24pm 30 October 2023 - πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
Opened MR with the fixes. Since we don't know in which version of commerce the payment_messages library will be available, we need to add it dynamically (check if it exists and then add it).
- πΊπΈUnited States rszrama
Are we sure the string of
../../../
there on image URLs is safe? Does core use that same pattern? Just concerned that we can't actually guarantee the module's placement in a directory structure and should probably copy images to our module instead. - πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
@rszrama
Are we sure the string of ../../../ there on image URLs is safe? Does core use that same pattern? Just concerned that we can't actually guarantee the module's placement in a directory structure and should probably copy images to our module instead.
Yes, you're right. I updated the MR here https://www.drupal.org/project/commerce/issues/3385414#comment-15295716 π Provide a basic replacement for Classy's messages library in the Payment module RTBC
- Status changed to RTBC
about 1 year ago 7:33pm 31 October 2023 - π¨π¦Canada sagesolutions
Adding the styling is now completed in the main commerce module, specifically https://www.drupal.org/project/commerce/issues/3385414#comment-15298522 π Provide a basic replacement for Classy's messages library in the Payment module RTBC
The patch #8 fixes the classy dependency error. Alternatively, MR #26 fixes the error too. Both fixes simply remove the dependency.
- π¨π¦Canada leducdubleuet Chicoutimi QC
Now that the fix in the issue #3385414 has landed in Commerce core 2.37, it would be great to have a new release including this fix please.
Thank you!
- First commit to issue fork.
- last update
11 months ago 38 pass - last update
11 months ago 38 pass -
TomTech β
committed 8cc62416 on 8.x-1.x authored by
vmarchuk β
Issue #3366832 by vmarchuk, elber, TomTech, Grimreaper, kiwad, rszrama,...
-
TomTech β
committed 8cc62416 on 8.x-1.x authored by
vmarchuk β
- Status changed to Fixed
10 months ago 3:52am 22 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.