Remove the Classy dependency for D10 compatibility

That was fast :)

I've tested with normal test card and insufficent funds test card it removes

User warning : The following theme is missing from the file system: classy dans Drupal\Core\Extension\ExtensionPathResolver->getPathname()

and

Deprecated function : dirname(): Passing null to parameter #1 ($path) of type string is deprecated dans Drupal\Core\Extension\ExtensionPathResolver->getPath()

in /checkout/{id}/review and checkout/{id}/order_information

Hi,

Thanks for the MR, I encountered the same issue and it fixed it.

Uploading patch for easier Composer usage.

Patch works for me on D10

I've noticed this issue during testing in a clean Commerce Kickstart 3.x instance as well.

@rszrama

I also noticed that we lost styles for error messages on D10. See the attached screenshot for more information.

So it seems we need to create our own styles if we don't want to have dependencies on other themes or modules.
Also, I see a dependency on "classy/messages" in the commerce_braintree module (we need to create an issue there), so maybe it makes sense to create global styles?

Ok, since this change simply removes styling that should be there, it's not an appropriate fix. Instead, we've created an issue against Commerce Core for defining a replacement library that this module can then be updated to use: 📌 Provide a basic replacement for Classy's messages library in the Payment module RTBC

Opened MR with the fixes. Since we don't know in which version of commerce the payment_messages library will be available, we need to add it dynamically (check if it exists and then add it).

Are we sure the string of ../../../ there on image URLs is safe? Does core use that same pattern? Just concerned that we can't actually guarantee the module's placement in a directory structure and should probably copy images to our module instead.

@rszrama

Are we sure the string of ../../../ there on image URLs is safe? Does core use that same pattern? Just concerned that we can't actually guarantee the module's placement in a directory structure and should probably copy images to our module instead.

Yes, you're right. I updated the MR here https://www.drupal.org/project/commerce/issues/3385414#comment-15295716 📌 Provide a basic replacement for Classy's messages library in the Payment module RTBC

Adding the styling is now completed in the main commerce module, specifically https://www.drupal.org/project/commerce/issues/3385414#comment-15298522 📌 Provide a basic replacement for Classy's messages library in the Payment module RTBC

The patch #8 fixes the classy dependency error. Alternatively, MR #26 fixes the error too. Both fixes simply remove the dependency.

+1, this takes care of all the warnings

Awesome thank you #8 removes the error

Now that the fix in the issue #3385414 has landed in Commerce core 2.37, it would be great to have a new release including this fix please.

Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.