- Issue created by @erdm
- π¬π§United Kingdom jaydenpearly
I have the same problem. Maybe it's ajax issue, I don't know. I send a message. It doesn't seem to be gone, but when I refresh the page, it appears in the stream.
- π·πΊRussia k.prozorov
I have prepared a patch that fixes this problem.
I removed the function call in the method and replaced it with the$response[] = $message;
construct.
I hope this helps. - last update
about 1 year ago 7 pass - Status changed to Needs review
about 1 year ago 5:18pm 30 August 2023 Hi k.prozorov,
Thanks for patch but it didn't work.
Unfortunately both 2 problems still exist.I confirm that the patch in #6 fixed this issue for me.
- I cannot reproduce the overlay issue. Not sure which overlay it is though, because I cannot see it while clicking on the "Load Previous" link.
- After applying this patch, the messages list started getting refreshed properly. If an AJAX refresh interval is set, it loads new messages after that interval, otherwise it loads instantly after form submission.
- Status changed to Needs work
7 months ago 4:22pm 14 April 2024 - π¨π¦Canada sagesolutions
Can confirm patch #6 does not fix the issue.
This is a javascript issue, which is breaking not only the load previous link, but all other links on the page no longer work when viewing the thread.
I can confirm that you can send 25 messages just fine, but once the "Load Previous" link appears, you cannot submit the next one.
Whichever link you click on a link or button, the page submits to "/private-message/ajax-callback/get_old_messages? token=W2RZzcxI6isICC5_MZYFCantGuhyx_slkOhHC8zUul8&threadid=123456&messageid=NaN" which has an e.preventdefault() which prevents the page from submitting/ loading.
- π¨π¦Canada sagesolutions
At some point the javascript functions were updated to use `() =>` notation.
However, using that broke the ability to use `$(this)` inside them. See https://www.freecodecamp.org/news/the-difference-between-arrow-functions... for a review of arrow functions.
I've replaced the `() =>` with `function()` and that worked for me. Will create a patch / MR shortly.
- Status changed to Needs review
7 months ago 1:50pm 27 April 2024 - π¨π¦Canada sagesolutions
Added patch that fixes the previous message issue. Please review!
- πΊπΈUnited States SocialNicheGuru
Will this be backported to private_message 3.0.0?
- π¨π¦Canada sagesolutions
@SocialNicheGuru I doubt it. Ideally they will tag a new release when they merge the MR
- Status changed to RTBC
6 months ago 1:30pm 26 May 2024 - πΊπΈUnited States SocialNicheGuru
This does not apply. Was it already applied to 3.0.1?
- πΊπΈUnited States loze Los Angeles
I believe this was fixed here π Revert the ESLint autommatted conversion to arrow functions - it broke multiple things Fixed
- π·π΄Romania claudiu.cristea Arad π·π΄
Is this still a problem with version 3.0.1?
- π¦πΉAustria drupalfan2
The problem still exists in v3.0.1 as you can see here:
https://www.drupal.org/project/private_message/issues/3486589 π Answer is not shown in message thread after posting a new reply Active