- Issue created by @Harish1688
- Assigned to shwetaDevkate
- Issue was unassigned.
- last update
almost 2 years ago Custom Commands Failed - Status changed to Needs work
almost 2 years ago 4:44pm 26 May 2023 There is a comment in the diff that says โiOSโ, which doesnโt really convey information and also this issue doesnโt mention specific browsers or platforms.
- Status changed to Needs review
almost 2 years ago 2:42am 29 May 2023 - last update
almost 2 years ago 29,399 pass - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have attached a patch and added the interdiff with #4. It was not just about padding property, the other properties like font-size, line-height and min-height were not same that's why styling was inconsistent. I have added all of them. please review
- Status changed to Needs work
almost 2 years ago 6:41am 29 May 2023 - ๐ฎ๐ณIndia Harish1688 India
Hi @Gauravvvv,
I thoroughly tested patch #6 and verified it functions correctly, successfully resolving the issue on popular browsers including Chrome, Safari, and Mozilla. However, it has inadvertently affected all text fields (input text, select box) styling throughout the claro theme, may be it should be limited only block layout page.
check patch impact on path:
admin/structure/types/manage/article
admin/structure/types/manage/article/form-display
images attached for references : - Status changed to Needs review
almost 2 years ago 4:28am 31 May 2023 - last update
almost 2 years ago 29,400 pass - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have fixed the issue and attached interdiff with #6. please review
- ๐ฎ๐ณIndia Harish1688 India
Hi @Gauravvvv,
I thoroughly tested (3362924-8.patch) and verified that it functions correctly, successfully resolving the issue on 'Structure -> Block layout' ,
but, it has inadvertently affected on path 'admin/structure/types/manage/article/form-display' (weight filed) styling. it should be theme like other sibling field. - First commit to issue fork.
- last update
almost 2 years ago Patch Failed to Apply - ๐ฆ๐บAustralia frank8199
I have attached a patch and added the interdiff with #8.
In order to keep consistency across different pages decided to NOT apply the modifier `extrasmall` to form select and form text elements.
Tested on following pages:
/admin/content
/admin/structure/types/manage/article/display
/admin/structure/block
/admin/structure/taxonomy/manage/tags/overview
/admin/structure/menu/manage/admin
/admin/people/roles
- last update
almost 2 years ago 29,400 pass - ๐ฆ๐บAustralia frank8199
Re-rolling patch #11 as it fails to apply.
- Status changed to Needs work
almost 2 years ago 2:30pm 31 May 2023 - last update
almost 2 years ago 29,400 pass - @frank8199 opened merge request.
- @frank8199 opened merge request.