- Issue created by @sboden
- 🇳🇱Netherlands Lendude Amsterdam
Yup that would be a nice addition, moving to the feature version
- Status changed to Needs review
about 1 year ago 10:58am 13 December 2023 - 🇳🇱Netherlands Lendude Amsterdam
Added functionality and a test for it, totally plagiarised from Webform
- Status changed to Needs work
about 1 year ago 3:41pm 13 December 2023 - 🇺🇸United States smustgrave
Could the issue summary be updated. Got it started but not as familiar with the issue.
- Status changed to Needs review
about 1 year ago 7:23am 14 December 2023 - Status changed to RTBC
about 1 year ago 2:27pm 14 December 2023 - 🇺🇸United States smustgrave
Thanks for the quick update!
Running test-only feature
1) Drupal\Tests\views_ui\Functional\DuplicateTest::testDuplicateView Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( - 'label' => 'NL label' ) /builds/issue/drupal-3360445/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94 /builds/issue/drupal-3360445/core/modules/views_ui/tests/src/Functional/DuplicateTest.php:66 /builds/issue/drupal-3360445/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 FAILURES! Tests: 1, Assertions: 15, Failures: 1.Following the steps I was able to confirm the issue and that the MR fixed it.
LGTM!
- 🇳🇿New Zealand quietone
This is a nice addition! I read the issue and the MR and didn't see any thing missing or that needs to change.
I tested this today on a fresh install of demo_umami and it worked perfectly. Thanks!
Leaving at RTBC.
- Status changed to Fixed
11 months ago 9:51am 26 January 2024 - 🇬🇧United Kingdom catch
This looks like something it would be good to have generic support for, but since we don't have generic support for duplcating config entities at all, that seems like long way off, if we ever were introduce it at all.
Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.