Fix PostgreSQL column name escaping in field constraints

Can the issue summary be updated to include the proposed solution and any api changes needed?

Also can a test be written to show the issue?

I've created two patches one with the change and one without and added one extra test to check the added functionality.

All code changes look good to me.
The patch with the added test fails without the fix.
I have updated the IS.
For me it is RTBC.

This no longer applies to 11.x

Fine to self RTBC after re-roll

Rerolled

The last submitted patch, 8: 3358609-8-pass.patch, failed testing. View results →

Mmmm, seems to me like a unrelated random fail. Let's try this one more time.

Testbot is green again.

+1 to this fix, looks good to me.

We are already quoting the name of the field when creating it:

  protected function createFieldSql($name, $spec) {
    // The PostgreSQL server converts names into lowercase, unless quoted.
    $sql = '"' . $name . '" ' . $spec['pgsql_type'];
    ...
  }

So we should quote the name in the great than zero check as well.

I have reviewed the patch and it seems like it contains a copy-pasted comment:

+    // First create the table with just a serial column.

I would say we should remove this comment, because it is not relevant here. Not changing the issue status, as I think this is a minor thing and probably could be fixed also on commit. Other that that, the patch looks good and it is working for me. Thanks!

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

I've created the branch and made a MR.

In the MR I've removed the comment mentioned by @poker10 in #12.

LGTM

Please remember to hide patch files when converting them to an MR. Thanks!

I posted some small coding standards fix suggestions on the MR. Thanks!

@xjm Thanks for the feedback en hiding the patch file, i've forgotten about that.
I've updated the MR with the suggested fixes.

The remarks from @xjm have been addressed.
Back to RTBC.

+1 for RTBC

All remarks of @xjm have been addressed.
Back to RTBC.

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do. This is also approved by the Database API maintainer.

Leaving at RTBC.

Needs another reroll, please ping me when done, fine to self RTBC - conflicts with 🐛 Fix PostgeSQL column name escaping in field constraints RTBC

Rebased to latest 11.x
I messed up the commits but all changes are there and postgresql tests pass

The reroll looks good. Compared the MR before and after and changes are the same:

https://git.drupalcode.org/project/drupal/-/merge_requests/5404/diffs?di...
https://git.drupalcode.org/project/drupal/-/merge_requests/5404/diffs?di...

Committed to 11.x

Needs re-roll for 10.2.x

Reroll for D10.2 looks good to me.

Committed e891703 and pushed to 10.2.x. Thanks!

Did not notice the typo in the title until after I pushed the commit.

Automatically closed - issue fixed for 2 weeks with no activity.