Fix the issues reported by phpcs

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\bootstrap_external_link_popup\bootstrap_external_link_popup.module ------------------------------------------------------------------------------------------------------------------------------ FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 36 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 37 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 38 | WARNING | [x] A comma should follow the last multiline array item. Found: ] ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ Time: 501ms; Memory: 6MB

Comments & Activities

Issue created by @sidharth_soman
Status changed to Active over 1 year ago8:18am 4 May 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Without patches or MRs, the status is still Active.
Status changed to Needs review over 1 year ago11:53am 4 May 2023
Comment over 1 year ago →
🇮🇳India arpitk
Worked on a patch. Adding screenshots for before and after applying patch.
Issue was unassigned.
Status changed to Needs work over 1 year ago12:56pm 4 May 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
Status changed to Needs review over 1 year ago11:14am 5 May 2023
Comment over 1 year ago →
🇨🇦Canada imustakim Canada
Issue summary updated.
Please review.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to RTBC 7 months ago5:02am 29 May 2024

Comment 7 months ago →

🇵🇭Philippines paraderojether

I reviewed Patch 3, applied against Bootstrap External Link Pop-up 2.x-dev and confirmed it fixes the issues reported by phpcs.

bootstrap_external_link_popup git:(2.x) curl https://www.drupal.org/files/issues/2023-05-04/fix-for-issues-reported-by-phpcs-3358093-3.patch | patch
 -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   736  100   736    0     0   1452      0 --:--:-- --:--:-- --:--:--  1474
patching file bootstrap_external_link_popup.module
➜  bootstrap_external_link_popup git:(2.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_external_link_popup
➜  contrib git:(main) ✗

Thank you.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities