Drupal 10 compatibility fixes

You can use this currently to install the module with the compatible dependency:

    {
      "type": "composer",
      "url": "https://packages.drupal.org/8",
      "exclude": [
        "drupal/views_templates",
        "drupal/calendar"
      ]
    },
    {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/views_templates-3299458.git"
    },
    {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/calendar-3356537.git"
    }

And in the "require" section:

    "drupal/calendar": "3356537-drupal-10-compatible-dev",
    "drupal/views_templates": "dev-3299458-automated-drupal-10 as 1.1"

You forgot a small part. Calendar depends on the core/jquery.farbtastic library as well, which is provided by the deprecated core/color module. So that needs to be replaced and make the contrib Color module a dependency.

You could also add the views_templates module in a lenient repository with the compose drupal lenient plugin, made by @mglaman (https://github.com/mglaman/composer-drupal-lenient)

Forgot the drupal/color dependency in the info.yml myself :-/

Thanks all for working on adding Drupal 10 compatibility to Calendar 1!

Calendar depends on the core/jquery.farbtastic library as well, which is provided by the deprecated core/color module.

The jquery.farbtastic library was provided by core, not by color module. But yes, it is now provided by the contrib color module as color/jquery.farbtastic and it seems like a reasonable idea to depend on contrib color module. Effectively this means that if this code gets merged today, then Calendar 1 will indirectly be depending on Drupal 9.4 going forward, and effectively alpha4 will be the last Calendar 1 release that runs on Drupal 8. Doesn't look like a problem to me, though...

The initial patch converts debug() to dump() while #5 converts debug() to $this->messenger->addWarning().
Core deprecation message for debug():

deprecated in drupal:9.2.0 and is removed from drupal:10.0.0. Use dump() instead.

The initial patch uses fully qualified names for the Twig classes, while #5 uses imports. Importing looks like the way to go to me.

Finally:

diff --git a/calendar.info.yml b/calendar.info.yml
index 1deda9a..5f4865c 100644
--- a/calendar.info.yml
+++ b/calendar.info.yml
@@ -4,8 +4,8 @@ description: 'Provides a Views plugin to display views containing dates as Calen
 dependencies:
   - calendar:calendar_datetime
   - drupal:views
+  - drupal:color
   - views_templates:views_templates

diff --git a/calendar.libraries.yml b/calendar.libraries.yml
index fc5f265..4fe1158 100644
--- a/calendar.libraries.yml
+++ b/calendar.libraries.yml
@@ -3,7 +3,7 @@ calendar.colorpicker:
   js:
     js/calendar_colorpicker.js: {}
   dependencies:
-    - core/jquery.farbtastic
+    - color/jquery.farbtastic

I think we should nstick with alphabetical order. It's the way to go to easily find stuff and to reduce chances on merge conflicts. (And latest Coder now even has a rule for this, if I'm not mistaken.)

Core deprecation message for debug():

deprecated in drupal:9.2.0 and is removed from drupal:10.0.0. Use dump() instead.

Actually, using dump() seems problematic outside of tests, given that symfony/var-dumper is not a dependency of drupal/core itself.

One more ordering issue:

diff --git a/composer.json b/composer.json
index 3421c73..432f446 100644
--- a/composer.json
+++ b/composer.json
@@ -21,7 +21,8 @@
     "source": "https://git.drupalcode.org/project/calendar"
   },
   "require": {
-    "drupal/core": "^8 || ^9",
-    "drupal/views_templates": "^1.1"
+    "drupal/core": "^8 || ^9 || ^10",
+    "drupal/views_templates": "^1.1",
+    "drupal/color": "^1.0"
   }
 }

Updated the patch to change the order of the dependencies in composer.json and the info.yml file.

Thank you!

I think it's indeed better to use the available messenger than using the dump() developer method which might not be available. The mesenger is already in use a couple of lines later at the end of the same render() method.
Wether it should be an error or a warning, could be a matter of taste here.

Also adding some related issues for Calendar 1 and Calendar 2.

Wait a minute... The Twig replacements might rule out Drupal 8 anyways... If so we should do so explicitly in info.yml en composer.json, because Drupal 8 then no longer conflicts because of a dependency, but because of of our own code.

Views template is now compatible with Drupal 10 so this ticket can now be worked on.

+1 RTBC

Carlos Romero → made their first commit to this issue’s fork.

Adding merge request and running tests

The last submitted patch, 11: 3356537-8.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I made some coding standard fixes the tests were complaining about, I'm not entirely sure the list change is correct.

I replaced farbtastic since it's removed in Drupal 10. I used the same process the new color module uses: https://git.drupalcode.org/project/color/-/blob/2.x/color.libraries.yml

There is an issue with month pagers with this implementation

Scratch that last comment, when I was testing I had rolled back a patch that fixes the issue I was experiencing. Re applying that patch I was able to complete testing.

Patch here: https://www.drupal.org/project/calendar/issues/2858086 🐛 view_args always contains the current date when using ajax pager Postponed: needs info

Moving back to needs review.

I am also undoing my last change since it's a pre existing bug and is resolved in another commit.

Drupal 9 EOL is close. Any active maintainer to merge this and tag a new release?

Thanks for pushing this along @nicxvan and all the others for helping. I've committed this to dev with a release coming in a few.

Automatically closed - issue fixed for 2 weeks with no activity.