Better default base path in assets stream wrapper

Don't mind marking this for ya.

Just for my own clarity it's fine to remove getType without a change record since it was just recently added to 10.1 which hasn't been released yet?

Oops actually that bit's for 🐛 Asset stream wrapper may need to be selected in the UI for some cases Active although not the right change for there either, need to drop that hunk from the patch here.

🐛 JS/CSS assets 404 by default on multisites Closed: duplicate .

If possible this could do with test coverage from the steps to reproduce in 🐛 JS/CSS assets 404 by default on multisites Closed: duplicate

Might have a test that fails - looks like setting file_public_path to NULL is the way to do it.

The last submitted patch, 8: 3354090-test-only.patch, failed testing. View results →

1) Drupal\FunctionalTests\Asset\AssetOptimizationTest::testAssetAggregationNoPublicPath
Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected.

That's what we want from the failing patch.

Remaining question for me, potentially for a follow-up but could also just do here:

1. Should we merge the two test methods back into one to avoid the extra install?

2. If not #1, should we use a data provider instead of a protected helper?

catch → credited mas5d2 → .

I think merging them is fine, if we add a comment to mention why we need to reset file_public_path here?

A bit short of time, but here's a merged test. Left the helper in because it's simpler, but one test method now.

I think this is fine.

Committed to 11.x and backported to 10.1.x

Automatically closed - issue fixed for 2 weeks with no activity.