- Issue created by @franckylfs
Thank you for the patch and for the stack trace.
This seems to be an unusual situation. I don't understand how $notification_emails could be unset at this line because just above this section it is set as:
$notification_emails = $config->get('notification.emails');
I think $notification_emails could be null here, but only if there is something wrong with the site configuration. notification.emails is set to an empty array on install and it is part of the update module schema. What does a var_dump of $notification_emails show?
I think the steps to reproduce need some refinement.
- Status changed to Postponed: needs info
over 1 year ago 5:29pm 21 April 2023 - 🇺🇸United States kwiseman
I was having the same issue. Uninstalling and then reinstalling Update Manager fixed it. The site is using Drupal 9.5.8 and PHP 8.1.13.
- 🇺🇦Ukraine goodboy Kharkiv, Ukraine
I am having the same issue.
$notification_emails
is NULL. - 🇱🇻Latvia Phonoman
The patch looks good and makes sense to include it in the core, IMO.
Calling a function that can break the page on unchecked variables is much worse than just adding a normal safety check. Perhaps the missing values come from old installs/configurations and/or migrations when it wasn't necessary. Reinstalling + importing configs will still remove the initially installed empty array when one wants to keep the original settings.You can also just manually add the missing value in update.settings.yml and import configs to resolve the issue as well, but better safe than sorry?
notification: emails: { }
- 🇺🇸United States texas-bronius
The suggested patch (explained in Proposed Resolution) worked for me, too. This D9 site on php 7.4 is being run on php 8.1.22 (8.0.0 removed the legacy param order, per changelog on php.net; info thanks to this smart guy)
- Status changed to Active
over 1 year ago 3:42am 8 September 2023 - 🇳🇿New Zealand quietone
I found a way to reproduce this which I added to the IS.
Turns out that notification.emails can be saved as string, an array or NULL. And it doesn't validate the email address either.
I wonder if there are duplicates of this.
19:26 18:38 Running- Status changed to Needs review
12 months ago 11:46am 27 January 2024 - Status changed to Active
11 months ago 6:47pm 28 January 2024 - 🇺🇸United States smustgrave
#9 seems @quietone was able to reproduce in 11.x branch.
- 🇪🇸Spain Juanjol Navarra
Still a problem in D10.2, attached patch with 10.2 version compatibility.
- Status changed to Needs review
10 months ago 12:42pm 27 February 2024 - Status changed to Needs work
10 months ago 1:04pm 27 February 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
- Status changed to Needs review
10 months ago 6:58am 28 February 2024 - Status changed to Needs work
10 months ago 7:27am 28 February 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
10 months ago 8:45am 28 February 2024 - 🇮🇳India sumit-k
Fixed core commit check issues. Changing status to Need Review.
- Status changed to Needs work
10 months ago 2:18pm 28 February 2024 - 🇺🇸United States smustgrave
Will need test coverage since it caused a fatal error.