Drupal 10 and CKEditor5 compatibility

Created a patch for Drupal 10 compatibility, please review.
Thank You.

With Drupal 10 here and reduced support for Drupal 8 going forward, I feel the info file should reflect the same. I have updated the core_version_requirement accordingly. Attached is the interdiff.

Thanks for the patches, but we are blocked by #3272732 https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed

For Drupal 10 and CKEditor5 compatibility:

We could try the following steps:
1. In the paragraphs_inline_entity_form.module file, replace the following code:

function paragraphs_inline_entity_form_editor_settings_alter(array &$settings) {
  $settings['drupal']['paragraphs']['drupalSettings']['editor']['autoEmbed_media_external']['enabled'] = FALSE;
}

With

use Drupal\editor\Entity\Editor;

function paragraphs_inline_entity_form_editor_settings_alter(array &$settings, Editor $editor) {
  if ($editor->getFilterFormat()->filters('filter_html')) {
    $settings['drupal']['paragraphs']['drupalSettings']['editor']['autoEmbed_media_external']['enabled'] = FALSE;
  }
}

2. In the composer.json file, add the following line to require the CKEditor5 package:
"ckeditor/ckeditor5": "^27.1.0"

3. Run composer update to install the CKEditor5 package.

4. In the paragraphs_inline_entity_form.libraries.yml file, replace the following code:

ckeditor:
  remote: https://cdn.ckeditor.com/4.7.3/full-all/ckeditor.js
  minified: true
  ...

with

ckeditor5:
  remote: https://cdn.ckeditor.com/ckeditor5/29.0.0/classic/ckeditor.js
  minified: true
  ...

5. Clear Drupal's cache to make sure the changes take effect.

This patch will update the Paragraphs Inline Entity Form module to use CKEditor5, making it compatible with Drupal 10. It also includes an update to the paragraphs_inline_entity_form_editor_settings_alter function to check whether the current filter format allows HTML tags before disabling the auto-embedding of external media.

@shivam_tiwari Thanks for the work on this, it will require some testing to validate the approach. Meanwhile, can you please rebase and update the pull request?

@marcelovani I am not getting any changes here after rebase. Please check and let me know if anything.

If you go to https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge... you will see the messages

Try to resolve on Gitlab itself by clicking the link on the message

Neither of these branches seem to contain a CKEditor 5 plugin. It install on Drupal 10 fine but CKEditor 5 compatibility is not ready yet.

Status for ckeditor 5

Ok clearly I didn't know this system nearly well enough to be commenting in #21 about there being no plugin, that's further up the chain. I stand by my comment on the MR about the library definition though.

I didn't dig too deep, but I suspect the plugin will need a rewrite to be compatible with cke5.

This module does work with a cocktail of patches on its dependencies, but if you're hoping to insert entities in-text like our use-case you'll be blocked by the new `entity_embed` widget which only injects entities at the block level, between

elements, not inside them.

That said, as far this module is concerned, I'd say it passes manual testing.

Let's hope this module is updated because for now I can only use the following module https://www.drupal.org/project/paragraphs_entity_embed → although it has its limitations

Would it be worth splitting the ckeditor 5 integration from the Drupal 10 compatibility? If nothing else it'd make the pieces easier to test on their own.

Also, if the changes for API compatibility mean that it's no longer compatible with DRupal 8, the info file should be updated to note this.

This project is very simple, it basically provides a custom Entity embed form that works as a glue to embed Paragraphs.

It depends on https://www.drupal.org/project/entity_embed/issues/3272732 ✨ Drupal 10 & CKEditor 5 readiness Fixed , that depends on https://www.drupal.org/project/embed/issues/3309747 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC

Looks like these two issues are getting close to be resolved, but we are not there yet.

Looks like the dependencies have been fixed, I will try to allocate some time to check this.

Attaching WIP PR https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge...
Currently blocked by https://www.drupal.org/project/entity_embed/issues/3396133 🐛 Ckeditor 5 Interface not loading on text formats using entity embed Active

Thank you everyone who has been contributing to this and all the related issues.

1. https://www.drupal.org/project/entity_embed/issues/3396133 🐛 Ckeditor 5 Interface not loading on text formats using entity embed Active was fixed!
2. I have installed the latest version of entity_embed →
3. I applied the patches from #32 ✨ Drupal 10 and CKEditor5 compatibility Needs work WIP PR
4. I enabled and configured CKEditor 5 for one of my text formats.
5. This all seems to be working without any errors on Drupal 9.5.10, I will report back when I update to Drupal 10

Thanks for checking @lexfunk and everyone that commented and tested this. I have just merged the PR https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge...
I will make a new release shortly.

Uploaded a video on Youtube

Drupal 10 Demo Video

Automatically closed - issue fixed for 2 weeks with no activity.

Reopened to merge parts of https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge...

marcelovani → closed merge request !3

marcelovani → closed merge request !4

I partially merged this PR in https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/commi... as the PR was not mergeable.

Automatically closed - issue fixed for 2 weeks with no activity.