Write tests

"it's not only the maintainers job!"
it takes a community, of course.

where is my paycheck (:

Here you go: 📌 Offering to co-maintain Language Switcher Fixed ;)
We're a small team, so payment isn't an option, but we'd like to help.

cheers. welcome home.

Most important task for a safe future of this module ;)

We're planning to work on this now!

Thanks @SKAUGHT I added your notes to the checklist! :)

What do you mean by Exception pages?

@Grevil will start working on this today.

FYI:

Enable only one language and test the block and its contents to show correctly.

This doesn't work, as if there is only one language enabled, the Block will not render, I feel like this behaviour is fine, as it does NOT display a broken block, but instead simply does not render it.

All done! Please review :)

I created another issue for further tests, see 📌 Write further tests Active .

Triggering tests (just configured)

I can review it.

Triggering the tests didn't work so far, let's try something different ...

Anybody → closed merge request !22

Anybody → reopened merge request !22

Does anyone have an idea how to trigger the tests here? ;)

No idea, so let's use the patch file then.

The last submitted patch, 30: dropdown_language-3348447-30.patch, failed testing. View results →

@Grevil: Some of the tests fail.

@Grevil: When finishing the tests here, please also see 🐛 Affected by core regression issue on no route match? Postponed and carry over the tests from the core issue, please. You can add theme here or in that issue, you can decide. Thanks :)

All tests are green local... going to see if I can find the reason they fail on remote.

Anybody → closed merge request !24

The module had wrong file permissions (chmod). Not your fault. Let's see if that's fixing this...

So we should definitely cherry-pick this to 3.x if it works.

Testbot still fails, I guess it's Drupal CI... let's merge this. Won't do any harm to the module itself.
Confirm tests to run green locally.

Cherry-picked into 3.2.x and 3.1.x!

PS: Tests pass, so it was a CI issue on the fork! ;)

https://www.drupal.org/node/2721679/qa →

So finally also cherry-picked into 3.0.x! Great work @Grevil! Thank you!

NEEDS WORK??

although this is now on 3.1, 3.2 & 4 branches reminder: this work has not been reviewed..