- Issue created by @Anybody
- @anybody opened merge request.
- Status changed to Postponed
over 1 year ago 7:08am 21 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
I prepared a MR with the code from the core issue.
But we should also please carry over the tests to our tests to ensure it works as expected.I used patch #36 as basis, let's now postpone this on the core issue and see what's the final outcome there. If anyone
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil could you please carry over the tests from #36 in https://www.drupal.org/project/drupal/issues/3348592 🐛 [regression] Language switcher block throws exception when no route is matched Fixed into this issue?
I think our block should just behave the same. - Status changed to Active
over 1 year ago 3:19pm 22 March 2023 - 🇩🇪Germany Grevil
Funny, in the added tests in https://www.drupal.org/project/drupal/issues/3348592 🐛 [regression] Language switcher block throws exception when no route is matched Fixed , they implemented the tests, like they are logged in as an anonymous user, but instead, they are logged in as an "admin" account which is not completely admin, so the tests still succeed.
- Status changed to Needs work
over 1 year ago 3:21pm 22 March 2023 - 🇩🇪Germany Grevil
Also, they check if the label of the block exists on a 403 page? That is super weird... Setting this to needs work, as it seems I do not understand the tests.
- Status changed to Postponed
over 1 year ago 3:44pm 22 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: If you're sure, please leave a note at the core issue.
Settings this back to PP on the core issue for now. Thanks for your work on this!
- Status changed to Closed: works as designed
over 1 year ago 4:10pm 22 March 2023 - 🇨🇦Canada SKAUGHT
seems like this is not an actual error/bug report, but a related concern about how/when core may change 'something' (:
closing. no proof.
- Status changed to Postponed
over 1 year ago 8:13am 27 March 2023 - 🇩🇪Germany Grevil
I guess we should still add the tests implemented in the core issue? Since the "no route matched" problem could also appear in our module due to some regression problems in the future?
- 🇩🇪Germany Grevil
FYI, @Anybody one of the core maintainers approved my problem, mentioned in #8, I created a follow-up issue, as expected by him: 📌 Partially refactor Language switcher block tests Active .