As of 🌱 [policy, no patch] Document named arguments BC policy Fixed named arguments are considered internal API. However, longwave pointed out in #3183180-24: [policy, no patch] Document named arguments BC policy → , an exception is needed. Here is that comment copied in full for convenience.
We will need an exception when 📌 Use PHP attributes instead of doctrine annotations Fixed lands, as named arguments in attributes are part of the API, by design.
The proposed Block attribute constructor is:
<?php
public function __construct(
public readonly string $id,
public readonly ?TranslatableMarkup $admin_label = NULL,
public readonly ?TranslatableMarkup $category = NULL,
public readonly array $context_definitions = [],
public readonly ?string $deriver = NULL,
public readonly array $forms = []
) {}
?>This is then invoked with named arguments:
<?php
#[Block(
id: "page_title_block",
admin_label: new TranslatableMarkup("Page title"),
forms: [
'settings_tray' => FALSE,
]
)]
?>Add an exception to the policy for PHP attributes.
TBA - proposed text
Closed: duplicate
11.0 🔥
Last updated
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Agreed named parameters in attributes should always be a part of the public API and subject to BC.
Closing as a duplicate of coding standards issue #3439004: Coding standard for attributes → .