- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
* @param array $form
+ * The Form array.
* @param \Drupal\Core\Form\FormStateInterface $form_state
+ * The For state.Form does not need to be capitalized since it is not a proper noun nor at the beginning of the sentence. The same is true for For, which is also a typo.
+ * The Form's pathauto_preview value.
That is another word that is not a proper noun nor at the beginning of the sentence. That description does not make clear what the returned value is.
I didn't find much AJAX callbacks that are implemented as functions, but the following has a different documentation comment, probably because, like form submission and validation handlers, their parameters are known.
/** * Ajax callback that returns the form element. */ function form_test_tableselect_ajax_callback($form, FormStateInterface $form_state) { return $form['tableselect']; }
- 🇮🇳India kkalashnikov Ghaziabad, India
Improve the typo and grammar in this patch.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
* Ajax callback that generates the URL-alias for an entity. * * @param array $form + * The form array. * @param \Drupal\Core\Form\FormStateInterface $form_state + * The form state. * * @return mixed + * The pathauto_preview value of the form. */
An AJAX callback does not need its parameters nor its return value described.
- // moment and the pathauto generator requires that the entity has an ID> + // moment and the pathauto generator requires that the entity has an ID>.
The > after ID is a typo. It needs to be removed.
- Status changed to Needs review
almost 2 years ago 6:05am 16 March 2023 Hi, reviewed the patch #6, applied cleanly , fixes all the reported phpcs errors and addresses the comments in #5.
- Status changed to RTBC
6 months ago 10:37am 26 June 2024