- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Discovered in 📌 GitExcluder should use ComposerInspector instead of ComposerUtility Fixed .
- 🇺🇸United States phenaproxima Massachusetts
I think we should standardize on "ignore", to match the name of the event.
- 🇺🇸United States phenaproxima Massachusetts
That says, it turns out it's a big lift to rename everything to "ignore". We might wanna standardize on "exclude" just for ease of conversion.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
What terminology does Composer Stager use? Should we match that? Why not?
- 🇺🇸United States phenaproxima Massachusetts
Hmmm...that's a good point.
Composer Stager says "exclusions" and variations thereof and I guess it might make sense to match that, to make it clear and explicit how we integrate with Composer Stager.
- Assigned to kunal.sachdev
- 🇮🇳India kunal.sachdev
So, as per #6 📌 Change 'ignore'/'ignored' to 'exclude'/'excluded' for consistent naming in public API: CollectIgnoredPathsEvent vs getExcludedPaths() Fixed should we change it to 'exclude' everywhere?
- 🇺🇸United States tedbow Ithaca, NY, USA
@kunal.sachdev yeah lets go with "excluded". thanks
- @kunalsachdev opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:17am 12 April 2023 - Status changed to Needs work
over 1 year ago 4:18pm 12 April 2023 - Assigned to kunal.sachdev
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:32am 13 April 2023 - Status changed to Needs work
over 1 year ago 8:42am 17 April 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Still change record. Beyond that, this is ready! 👍
- Assigned to kunal.sachdev
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:28am 18 April 2023 - Status changed to RTBC
over 1 year ago 9:55am 18 April 2023 - Status changed to Needs work
over 1 year ago 1:08pm 18 April 2023 - 🇺🇸United States phenaproxima Massachusetts
Looks like this needs a rebase/merge conflict fix, but once that's done I'm gonna commit it.
- last update
over 1 year ago 715 pass - Assigned to phenaproxima
- Status changed to Needs review
over 1 year ago 2:00pm 18 April 2023 - Status changed to RTBC
over 1 year ago 2:03pm 18 April 2023 - last update
over 1 year ago 715 pass -
phenaproxima →
committed 57ee1b9b on 3.0.x authored by
kunal.sachdev →
Issue #3346659 by kunal.sachdev, phenaproxima, Wim Leers: Change 'ignore...
-
phenaproxima →
committed 57ee1b9b on 3.0.x authored by
kunal.sachdev →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:06pm 18 April 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Published https://www.drupal.org/node/3354597 → .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- 🇺🇸United States tim.plunkett Philadelphia
PB was using class_exists(CollectIgnoredPathsEvent) to check if PM was truly available. I think that may have been a 2.4 vs 2.5 concern. I opened 🐛 Adapt to rename of CollectIgnoredPathsEvent Fixed to swap the event, but if someone from AU could chime in to see if we can simplify that condition, that'd be much appreciated
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@phenaproxima already responded: #3356614-2: Adapt to rename of CollectIgnoredPathsEvent → .
Automatically closed - issue fixed for 2 weeks with no activity.