- Issue created by @wim leers
- First commit to issue fork.
- @phenaproxima opened merge request.
- Assigned to tedbow
- Status changed to Needs review
over 1 year ago 1:45am 4 March 2023 - Assigned to wim leers
- Status changed to Needs work
over 1 year ago 5:33pm 7 March 2023 - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 5:50pm 7 March 2023 - Assigned to wim leers
- Status changed to Needs work
over 1 year ago 6:10pm 7 March 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
@Wim Leers sorry I didn't realize a problem with the idea until I saw it done
- Assigned to tedbow
- πΊπΈUnited States tedbow Ithaca, NY, USA
The functional tests that failed here https://www.drupal.org/pift-ci-job/2611778 β pass for me locally. Will wait to investigate until the next test run comes back
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:11pm 7 March 2023 - Assigned to phenaproxima
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 8:23pm 7 March 2023 - πΊπΈUnited States phenaproxima Massachusetts
@tedbow explained the rationale for his changes to me over Zoom. Although I'd like Wim's +1 before we commit this, I'll RTBC once Ted makes the changes I've asked for, especially the one about where we throw the LogicException.
I like Ted's approach of making sure we present the user with the problem that caused CollectIgnoredPathsEvent to fail. That keeps things transparent and debuggable, and means we don't have to write a whole other validator. What's not to like?
- Status changed to Needs review
over 1 year ago 8:55pm 7 March 2023 - Assigned to phenaproxima
- Assigned to wim leers
- Status changed to RTBC
over 1 year ago 9:26pm 7 March 2023 - πΊπΈUnited States phenaproxima Massachusetts
I think this is good.
RTBC assuming tests pass, and assigning to Wim for final sign-off on what we did here, and (if he feels like it) commit.
-
Wim Leers β
committed e7953e24 on 3.0.x authored by
phenaproxima β
Issue #3345762: GitExcluder should use ComposerInspector instead of...
-
Wim Leers β
committed e7953e24 on 3.0.x authored by
phenaproxima β
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 11:46am 8 March 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Did a thorough final review before merging (only spotted 2 tiny nits: one comment, one strict types declaration), merged in upstream β¦ all green so: π’
This unblocked π UnknownPathExcluder should use ComposerInspector instead of ComposerUtility Fixed .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Follow-up created for pre-existing problem I spotted during my final review: π Regression in #3343827: GitExcluderTest should test with composer/installers enabled Fixed .
Automatically closed - issue fixed for 2 weeks with no activity.