- Issue created by @wim leers
- Assigned to kunal.sachdev
- @kunalsachdev opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:54pm 7 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@tedbow's feedback is addressed, which removes the need for issue summary updates and a follow-up.
I:
- implemented
composer config --file
, as discussed during yesterday's meeting - proved to @tedbow that we're tightly complying with
composer.lock
validation by tightening that validation — even though that's arguably out of scope. I figured since the question was surfaced here, it was worth tightening here. I'm fine with splitting it off to a separate issue though.
- implemented
- Assigned to wim leers
- Status changed to Needs work
almost 2 years ago 3:08pm 7 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Deferring the strict lock checking to 📌 Explicitly validate lock files everywhere: `composer validate --check-lock` Fixed .
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:52pm 7 March 2023 - Status changed to Needs work
almost 2 years ago 4:25pm 7 March 2023 - 🇺🇸United States phenaproxima Massachusetts
One pointed question, one potential small refactor...
- Status changed to Needs review
almost 2 years ago 4:29pm 7 March 2023 - Status changed to RTBC
almost 2 years ago 4:39pm 7 March 2023 - Status changed to Needs review
almost 2 years ago 4:53pm 7 March 2023 - 🇺🇸United States phenaproxima Massachusetts
Sorry, still not grokking something. I will hop in a Zoom or something to clear it up...
- Status changed to Postponed
almost 2 years ago 5:55pm 7 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Per https://git.drupalcode.org/project/automatic_updates/-/merge_requests/75..., I think this should be postponed on 📌 GitExcluder should use ComposerInspector instead of ComposerUtility Fixed to avoid having the same discussion in two places.
- Status changed to Needs work
almost 2 years ago 11:46am 8 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- Assigned to phenaproxima
- Status changed to RTBC
almost 2 years ago 1:58pm 8 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
IMO this is now ready — curious to hear what @phenaproxima thinks!
- Status changed to Needs work
almost 2 years ago 4:24pm 8 March 2023 - 🇺🇸United States phenaproxima Massachusetts
Discussed with Wim and I think this is mostly really good. I approve of the added explicitness in calling ComposerInspector::validate().
There are a couple of things we should streamline, though, for clarity. Self-assigning to handle those.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Changes look good, 🚢 (but first fix the failures due to expectations needing updates)
- Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 5:53pm 8 March 2023 - 🇺🇸United States phenaproxima Massachusetts
Assigning to Wim for final review and commit.
-
Wim Leers →
committed 07c1435b on 3.0.x authored by
kunal.sachdev →
Issue #3345763: UnknownPathExcluder should use ComposerInspector instead...
-
Wim Leers →
committed 07c1435b on 3.0.x authored by
kunal.sachdev →
- Issue was unassigned.
- Status changed to Fixed
almost 2 years ago 11:06am 9 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Marked #3344583 as NW as very helpfully suggested by @phenaproxima: #3344583-19: ComposerInspector::validate() should throw ComposerNotReadyException instead of \Exception → 😊
📌 Explicitly validate lock files everywhere: `composer validate --check-lock` Fixed is now less postponed: #3346520-4: [PP-1] Explicitly validate lock files everywhere: `composer validate --check-lock` → .
Automatically closed - issue fixed for 2 weeks with no activity.