Contrib.social

Adapt to rename of CollectIgnoredPathsEvent

Open on Drupal.org →
Created on 26 April 2023, over 2 years ago
Updated 1 May 2023, over 2 years ago

Problem/Motivation

📌 Change 'ignore'/'ignored' to 'exclude'/'excluded' for consistent naming in public API: CollectIgnoredPathsEvent vs getExcludedPaths() Fixed broke PB tests

Steps to reproduce

Assuming that you have AU and PB installed via composer but as git repos, from within AU run:

git bisect start 58c9abd3 92fd3c01
git bisect run ../../../../vendor/bin/phpunit -c ../../../core  --filter=testUiInstallNeedsPackageManager ../project_browser/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php

Result

commit 57ee1b9bf0c4281169afbf8afdee0d9103965b36 (HEAD)
Author: Kunal Sachdev <57170-kunal.sachdev@users.noreply.drupalcode.org>
Date:   Tue Apr 18 14:05:52 2023 +0000

    Issue #3346659 by kunal.sachdev, phenaproxima, Wim Leers: Change 'ignore'/'ignored' to 'exclude'/'excluded' for consistent naming in pub
lic API: CollectIgnoredPathsEvent vs getExcludedPaths()

Proposed resolution

Switch fro checking for CollectIgnoredPathsEvent to CollectPathsToExcludeEvent

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024