Remove possible duplicate test XssUnitTest::testBadProtocolStripping

Created on 27 February 2023, over 1 year ago

Problem/Motivation

While working on πŸ“Œ Fix class comment doc blocks in tests for 'Drupal.Commenting.DocComment.ShortSingleLine' Fixed I noticed that \Drupal\KernelTests\Core\Common\XssUnitTest appears to be duplicating tests that are elsewhere.

testBadProtocolStripping(). This is testing URL helper methods which are tested in \Drupal\Tests\Component\Utility\UrlHelperTest and with what appears to be more robust test data.

testT() - Surely t() has better testing elsewhere?

\Drupal\KernelTests\Core\Common\XssUnitTest was added in #1598564: Convert common.test to PSR-0 β†’

Steps to reproduce

Proposed resolution

Remove testBadProtocolStripping and possibly testT()

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

10.1 ✨

Component
BaseΒ  β†’

Last updated about 10 hours ago

Created by

πŸ‡³πŸ‡ΏNew Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024