- Issue created by @Wim Leers
- Status changed to Needs review
over 1 year ago 7:45am 23 February 2023 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
… and this likely simplifies future improvements, such as ✨ Make it possible for contrib modules to reuse core's commit-code-check.sh Needs work .
- Status changed to RTBC
over 1 year ago 5:27pm 27 February 2023 - 🇺🇸United States smustgrave
Did a familiar test that I did for 📌 Fix cspell use: specify globRoot and always pass --root to cspell Fixed
Tested by adding some junk into action.module. "ewfdsafdsa"
Running ./core/scripts/dev/commit-code-check.sh flagged it.So functionality seems to still be there.
The last submitted patch, 2: 3343919-2.patch, failed testing. View results →
- 🇳🇿New Zealand quietone New Zealand
It was a random test failure, restoring RTBC
- Status changed to Needs work
over 1 year ago 11:11am 9 March 2023 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Needs reroll now that 📌 Fix cspell use: specify globRoot and always pass --root to cspell Fixed is in!
- First commit to issue fork.
- @rpayanm opened merge request.
- Status changed to Needs review
over 1 year ago 9:17pm 10 March 2023 - Status changed to RTBC
over 1 year ago 10:56pm 12 March 2023 - 🇺🇸United States smustgrave
Reroll seems fine. Did the same steps I did in #4
- Status changed to Needs work
over 1 year ago 1:38am 13 March 2023 - 🇳🇿New Zealand quietone New Zealand
A nice tidy up.
I manually tested this and spellcheck was not running on my changed files. See the MR.
