Deprecate LinkGeneratorInterface::generateFromLink()

Filed CR and patch, not sure if deprecation needs separate method as generate() also should become internal

I think this needs to point to Link::fromTextAndUrl() for the alternative so it's not @internal. But otherwise looks good.

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Link.php/...

It can't point to Link::fromTextAndUrl() because this method returns GeneratedLink object but Link is renderable element

Oh now I see... this is what gets called by Link::toString().

So all we're doing is removing an internal wrapper for another internal method, it's slightly odd that the deprecation points there, but in practice people should already not be using this, so they won't see it, and if they are, then worst thing is they use ::generate() instead which will be no worse than they're already doing.

The deprecation message for a method → does not start with 'The'. And I was getting a phpcs error on the deprecation message in the interface.

I updated the patch.

My bad, thank you for fix

Committed and pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.