- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:23am 16 February 2023 - Assigned to spriya2896
- š®š³India spriya2896
I have tested this patch. This patch was applied successfully and shows no phpcs errors.
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 5:23am 16 February 2023 - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 8:08pm 1 May 2023 - š®š¹Italy apaderno Brescia, š®š¹
It would be better that the patch is reviewed by somebody who does not work on the same organization.
- Status changed to RTBC
over 1 year ago 1:35am 2 May 2023 - šµšPhilippines paraderojether
I reviewed patch #2, and verified it fixes the issues reported by the phpcs. Drupal core version 9.5.8, and Views Remote Data 1.0.X-dev.
I added screenshots for reference.
Thank You. - First commit to issue fork.
- Status changed to Needs review
7 months ago 4:14pm 24 June 2024 - Status changed to Needs work
6 months ago 2:26pm 21 July 2024 - šµšPhilippines clarkssquared
Hi
I applied the updated MR !20 after commit #14 and I can still see many PHPCS issues:
ā views_remote_data git:(1.0.x) curl https://git.drupalcode.org/project/views_remote_data/-/merge_requests/20.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6783 0 6783 0 0 13277 0 --:--:-- --:--:-- --:--:-- 13647 patching file 'tests/src/Kernel/Events/RemoteDataQueryEventTest.php' patching file 'tests/src/Kernel/Plugin/views/ViewsPluginTestBase.php' patching file 'tests/src/Kernel/Plugin/views/argument/PropertyArgumentTest.php' patching file 'tests/src/Kernel/Plugin/views/field/PropertyFieldTest.php' patching file 'tests/src/Kernel/Plugin/views/filter/PropertyFilterTest.php' patching file 'tests/src/Kernel/Plugin/views/query/RemoteDataQueryTest.php' patching file 'tests/src/Kernel/Plugin/views/sort/PropertySortTest.php' ā views_remote_data git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_remote_data FILE: ...ta_pokeapi/config/install/core.entity_view_display.node.pokemon.teaser.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 35 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...a_pokeapi/config/install/core.entity_view_display.node.pokemon.default.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 34 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ontrib/views_remote_data/tests/modules/views_remote_data_pokeapi/README.md -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 119 characters 6 | WARNING | Line exceeds 80 characters; contains 119 characters 11 | WARNING | Line exceeds 80 characters; contains 111 characters 16 | WARNING | Line exceeds 80 characters; contains 89 characters -------------------------------------------------------------------------------- FILE: ...ws_remote_data/tests/src/Kernel/Events/RemoteDataLoadEntitiesEventTest.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Serialization\Json. 26 | ERROR | [x] Expected 1 blank line before function; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../Projects/d10/drupal_local/web/modules/contrib/views_remote_data/README.md -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 119 characters -------------------------------------------------------------------------------- Time: 754ms; Memory: 12MB ā contrib git:(main) ā
- Status changed to Needs review
6 months ago 4:43pm 21 July 2024 - š®š³India ankitv18
Rebased and made minor changes to make pipelines green for all.
-
mglaman ā
committed 9249a485 on 1.0.x authored by
ankitv18 ā
Issue #3342224 by ankitv18, samit.310@gmail.com, urvashi_vora,...
-
mglaman ā
committed 9249a485 on 1.0.x authored by
ankitv18 ā
- Status changed to Fixed
6 months ago 3:06pm 22 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.