- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 4:36am 9 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- @charchil-khandelwal opened merge request.
- Issue was unassigned.
- Assigned to yashmalviya
- Status changed to Needs work
almost 2 years ago 12:18pm 24 June 2023 - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:24pm 24 June 2023 - ๐ฎ๐ณIndia yashmalviya
I have added a patch for the issue. Please Review
- last update
almost 2 years ago Patch Failed to Apply - Status changed to Needs work
almost 2 years ago 7:42pm 25 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- * composer config repositories.owlcarousel2 '{"type":"package","package":{"name":"owlcarousel2/ owlcarousel2","version":"2.3.4","type":"drupal-library","dist":{"type":"zip","url":"https://github.com/OwlCarousel2/OwlCarousel2/archive/2.3.4.zip"}}}' + * composer config repositories.owlcarousel2 '{"type":"package", + "package":{"name":"owlcarousel2/ owlcarousel2", + "version":"2.3.4","type":"drupal-library","dist":{"type":"zip","url":"https://github.com/OwlCarousel2/OwlCarousel2/archive/2.3.4.zip"}}}'
Since that is a CLI command, it should be formatted differently. Probably, it is also better to leave that line as it is.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:38am 26 June 2023 - Status changed to Needs work
almost 2 years ago 7:48pm 26 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
-This module integrates Owl Carousel, a touch enabled jQuery plugin that lets you create a beautiful, responsive carousel sliders. +This module integrates Owl Carousel, +a touch enabled jQuery plugin that lets you create a beautiful, + responsive carousel sliders.
Avoiding that lines exceed 80 characters does not mean making them 37 characters. Lines do not need to be split at punctuation marks.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:25pm 28 June 2023 - ๐จ๐ฆCanada imustakim Canada
Patch Updated, addressed #14 ๐ Fix the issues reported by phpcs Fixed and resolved a dependency injection warning.
Still there is one warning in readme.md file Line exceeds 80 characters; contains 251 characters, it contains link so assuming this can be ignored.
Rest of the warnings and errors are resolved. - Status changed to Fixed
over 1 year ago 9:55am 14 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.