- Issue created by @Charchil Khandelwal
- @charchil-khandelwal opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:15am 6 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Created MR !3 for this issue.
Please review.Thanks.
- Status changed to Needs work
over 1 year ago 6:30pm 8 February 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Ashutosh Ahirwal โ made their first commit to this issueโs fork.
- @ashutosh-ahirwal opened merge request.
- Status changed to Needs review
over 1 year ago 10:30am 22 May 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Created MR 5 with phpcs issur fixes in module.
- Status changed to Needs work
over 1 year ago 2:37am 23 May 2023 - ๐ต๐ญPhilippines paraderojether
I reviewed MR5, and there are still remaining issues reported by phpcs shown below:
FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/config_plus/src/ConfigInstaller.php ---------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 12 LINES ---------------------------------------------------------------------------------------------------------------------- 78 | ERROR | [x] Expected "\Drupal\config_rewrite\ConfigRewriter|null" but found | | "\Drupal\config_rewrite\ConfigRewriter|NULL" for @var tag in member variable comment 110 | ERROR | [x] Expected "\Drupal\config_rewrite\ConfigRewriter|null" but found | | "\Drupal\config_rewrite\ConfigRewriter|NULL" for parameter type 112 | ERROR | [x] Expected "\Drupal\Core\Logger\LoggerChannelInterface|null" but found | | "\Drupal\Core\Logger\LoggerChannelInterface|NULL" for parameter type 134 | ERROR | [ ] Missing parameter type 136 | ERROR | [ ] Missing parameter type 138 | ERROR | [ ] Missing parameter type 142 | ERROR | [ ] Description for the @return value is missing 143 | ERROR | [x] Separate the @return and @throws sections by a blank line. 208 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 209 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces 211 | ERROR | [ ] Description for the @return value is missing 260 | ERROR | [ ] The array declaration extends to column 159 (the limit is 80). The array content should be split | | up over multiple lines ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- Time: 207ms; Memory: 10MB
Please check.
Thank You. - Assigned to bharath-kondeti
- Issue was unassigned.
- ๐ฎ๐ณIndia bharath-kondeti Hyderabad
Looks like all phpcs issues are addressed in MR5
- Assigned to nitin_lama
- ๐ฎ๐ณIndia nitin_lama India
@nisha_j whenever there is an open MR, try to commit your changes in the MR itself instead of providing a patch. Also patch #12, doesn't applies to branch 1.0.x.
I've reviewed both MR3 and MR5, and it seems like all PHPCS issues are addressed in both MRs. @ashutosh_ahirwal I'm not sure why MR5 was opened when there was already MR3. :/
- Status changed to Needs review
11 months ago 9:46am 7 December 2023 - Issue was unassigned.