- Issue created by @Jay Jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 5:20pm 3 May 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Jay Jangid
I applied your MR to the โAMP Optimizerโ module and confirmed that the phpcs issues are resolved. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
over 1 year ago 6:54am 4 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * Class OptimizerSubscriber. - * - * @package Drupal\amp_optimizer\EventSubscriber + * Summary of OptimizerSubscriber. */
/** - * @var \Drupal\Core\Session\AccountProxyInterface + * Summary of currentUser. + * + * @var mixed */ protected $currentUser;
+ /** + * Summary of __construct. + * + * @param \AmpProject\Optimizer\TransformationEngine $transformation_engine + * The transformation_engine. + * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory + * The config_factory. + * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $logger_channel_factory + * The logger_channel_factory. + * @param \Drupal\Core\Session\AccountProxyInterface $current_user + * The current_user. + */ public function __construct(TransformationEngine $transformation_engine, ConfigFactoryInterface $config_factory, LoggerChannelFactoryInterface $logger_channel_factory, AccountProxyInterface $current_user) {
Summary of is not a description for a class, a method, or a parameter.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:11pm 9 May 2023 - Status changed to Needs work
over 1 year ago 5:16pm 9 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * Class OptimizerSubscriber. + * An eventsubscriber of amp_optimizer. *
eventsubscriber are two words.
A class description must not include the module machine name; eventually, it should describe the class without using a generic description like An event subscriber.- * @param Response $response - * @param Request $request + * Checks if the response format is html.
As acronym, it is spelled HTML.
* @return bool + * FALSE if the response is not instance of htmlresponse. */
an is missing before instance of. If
htmlresponse
is the class name, it must be written using the same uppercase/lowercase characters. - Assigned to nitin_lama
- @nitin_lama opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:25am 10 May 2023 - First commit to issue fork.
-
voleger โ
committed 16e08e80 on 1.0.x authored by
nitin_lama โ
Issue #3338813 by Jay Jangid, nitin_lama, imustakim, apaderno: Fix the...
-
voleger โ
committed 16e08e80 on 1.0.x authored by
nitin_lama โ
- Status changed to Fixed
about 1 year ago 9:19pm 25 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.