- Issue created by @diegors
- Status changed to Needs review
almost 2 years ago 12:15am 2 February 2023 - 🇧🇷Brazil diegors Campinas - Brazil
Removed the CSS selector, I am not sure if this approach is the best, I did some tests and the download is normal. Please review.
- 🇺🇸United States jrockowitz Brooklyn, NY
I think we can just ::marker
@see https://developer.mozilla.org/en-US/docs/Web/CSS/::marker
- Status changed to RTBC
almost 2 years ago 1:18am 2 February 2023 -
jrockowitz →
authored 70a04f76 on 6.1.x
Issue #3338428 by diegors, jrockowitz: Failed to generate PDF
-
jrockowitz →
authored 70a04f76 on 6.1.x
-
jrockowitz →
authored 70a04f76 on 6.x
Issue #3338428 by diegors, jrockowitz: Failed to generate PDF
-
jrockowitz →
authored 70a04f76 on 6.x
-
jrockowitz →
authored 70a04f76 on 6.2.x
Issue #3338428 by diegors, jrockowitz: Failed to generate PDF
-
jrockowitz →
authored 70a04f76 on 6.2.x
- Status changed to Fixed
almost 2 years ago 8:11pm 3 February 2023 - 🇩🇪Germany macdev_drupal Wiesbaden
Running with Core 9.4.10, entity_print 2.11.0 and webforms 6.1.4 with Patch #3 I do get the error:
Error generating document: Failed to generate PDF: The CSS selector 'summary::marker' is not valid
When I apply patch #2 it works.
- 🇧🇪Belgium bartvermeulen1
I'm running core 9.5.3, webform 6.1.4 and entity_print 2.11. With patch #3 I also get the error "Error generating document: Failed to generate PDF: The CSS selector 'summary::marker' is not valid"
Patch #2 works
- 🇨🇦Canada joelseguin Ontario, Canada
Did some quick research and tested out the latest patch.
Patch #3 doesn't work since DOMPDF likely does not support the ::marker pseudo element. ::marker is not part of the CSS 2.1 spec (https://www.w3.org/TR/CSS2/) which DOMPDF mostly adheres to as per https://github.com/dompdf/dompdf.
Patch 2 removes the use ::marker altogether which is likely the only way to avoid the error.
- 🇳🇱Netherlands ecvandenberg
PHP 7.4.33, Core 9.5.3, Webform 6.1.4, Entity print 8.x-2.11
with patch #2 works for me. - 🇮🇹Italy kris77
Patch #2 works for me.
Drupal 9.5.3 - PHP 8.1 - Webform 6.1.4 - Entity_Print 8.x-2.11Thanks @diegors
- Status changed to Needs review
over 1 year ago 5:00pm 7 March 2023 - 🇨🇦Canada spotzero
I was getting the inital issue with the latest release (Webform 6.1.4), switching to 6.1.x (33949ef) changed the error message to:
Error generating document: Failed to generate PDF: The CSS selector 'summary::marker' is not valid
This matches the experience of last several commenters, to I'm going to update this issue to "Needs review".
- 🇺🇦Ukraine zegmant
the same error
Error generating document: Failed to generate PDF: The CSS selector 'summary::marker' is not valid
D 9.5.4
Webform 6.1.4 - 🇪🇸Spain Sistemas SUMADOS
#2 and # 3 works for me.
Drupal: 9.5.7
PHP: 8.1
MySQL: 5.7
entity_print: 8.x-2.11
webform: 6.1.4 - Status changed to RTBC
over 1 year ago 11:34am 5 April 2023 - 🇵🇭Philippines roberttabigue
Hi @diegors,
I'm new to this module and confirmed resolved the issue when I applied patch #2 to the "Webform" module against 6.1.x-dev. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Fixed
over 1 year ago 10:48pm 11 April 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
Since this is a somewhat backward compatibility issue, I am going to make this change to 6.2.x and users of 6.1.x should use the patch or upgrade.
-
jrockowitz →
authored 7bfced8c on 6.2.x
Issue #3338428 by jrockowitz, diegors: Failed to generate PDF
-
jrockowitz →
authored 7bfced8c on 6.2.x
Just found this. Glad to see it's already fixed. Thanks, everyone!
- Status changed to Fixed
over 1 year ago 8:54pm 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇲🇽Mexico prcwest
Just installed webform 6.2.0-beta6 and he error is still there. Error generating document: Failed to generate PDF: The CSS selector 'summary::-webkit-details-marker' is not valid. Does this mean i need patch 2?
Best regards
It works for me after updating. No patch. I did have some database updates to run after I updated, but that might have been another module. Did you run updates and clear the cache?
- 🇨🇦Canada spotzero
After the release of 6.15, the patch no longer applies and the error message is "Error generating document: Failed to generate PDF: The CSS selector 'summary::marker' is not valid".
Here is the updated patch for 6.1.x.
@pcrwest After your patch failed to apply, it's possible your code isn't getting updated by Composer, even after you remove the patch.
Look at the file webform_entity_print.css. If you search for the text
marker
, you should have no results. If you do have results, it's probably because of some issue with the patching process. Try deleting your composer.lock file, then runningcomposer update --with-all-dependencies
, or you can try reinstalling just the webform module. Otherwise, delete that one CSS file, then re-pull it into your repository, and try patching again.- 🇲🇽Mexico prcwest
Tank you @solideogloria.
You are correct. The webform_entity_print.css is not showing any marker.
Y tried all your suggestions, deleted composer.lock file and run composer update --with-all-dependencies , deleting the css file, and reinstalled the webform module without success. After i updated the module from 6.1 to 6.2 i run updates and deleted cache. Still having the same error.- Removing drupal/webform (6.2.0-beta6)
Deleting modules/contrib/webform - deleted
- Downloading drupal/webform (6.2.0-beta6)
- Installing drupal/webform (6.2.0-beta6): Extracting archive