🇧🇷Brazil @diegors

greggles → credited diegors → .

Hello @vedia it's not necessary to be a confirmed user to post past or open MR, you can follow the how to contribute guide → .

Thanks, @RenatoG for contribution.

The license now is correct.

Moving to RTBC.

Agree with @Wim Leers in #3, removed the $this->(), NR.

diegors → made their first commit to this issue’s fork.

Thanks, @RenatoG for contribution.

The license now is correct.

Moving to RTBC.

@amarshkhl09 I tested in my local env using a test.hml page.

Removed the CSS selector, I am not sure if this approach is the best, I did some tests and the download is normal. Please review.

diegors → created an issue.

Rebase done.

diegors → made their first commit to this issue’s fork.

The documentation is great for me, reviewed, and the filer follows the README.md template → . Moving to RTBC.

Did the rebase, MR is mergeable.

Patch rerolled.

Fixed the tests, still need FE part as suggested in #22

diegors → made their first commit to this issue’s fork.

I think this issue can be closed as won't fix.

Running the test on modal_page 5.0.x, no errors found:

PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing /app/web/modules/contrib/modal_page/tests
.....................                                             21 / 21 (100%)

Time: 00:22.901, Memory: 16.00 MB

OK (21 tests, 50 assertions)

Working on it.

diegors → made their first commit to this issue’s fork.

I could not reproduce the bug, tested using Drupal 9.5.2 and Olivero theme using fixed and Resizing iframe, both of the scrolled to the top.

Working on it.

I did some changes, In file tests/valid_path.test in:

/**
   * Protected property of created order.
   *
   * @var mixed
   */
  protected $order;

I am not sure about the @var mixed, I think it should be a specific type.

Did some changes, needs review.

Working on it.

Applied the patch and works.

Before patch:

After patch:

Moving to RTBC.

It was a small change, just check if file is new before validate.

Please review.

working on it.

Add a return checkProtectedPage() method and send a HTTP_NO_CONTENT in response fixed the problem, please review.

Working on it.

Fixed the tests and some coding standard errors in test file.

Still need review.