- Issue created by @tedbow
- @tedbow opened merge request.
- Status changed to Needs work
almost 2 years ago 11:33pm 5 February 2023 - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
I wanted to RTBC, but wrapping a variable or function call in a
$this->()
really does not make sense ๐ - First commit to issue fork.
- Status changed to Needs review
almost 2 years ago 12:30am 6 February 2023 - Status changed to RTBC
almost 2 years ago 10:47am 6 February 2023 - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Thank you, @diegors! ๐
- Status changed to Needs work
almost 2 years ago 3:06pm 6 February 2023 - ๐ฎ๐ณIndia omkar.podey
Things that seem confusing
- So looking at
\Drupal\package_manager\Validator\ComposerExecutableValidator::setError
it puts an untranslated string in between a translatable string, is that a good idea ?
- Isn't the bigger issue that we are getting untranslated strings from composer stager and we still want to display them to user as translated strings?
- Since we are already doing point 1 can we just put an else and always convert the string to a translatable but does that make sense ?
- So looking at
- Assigned to tedbow
- ๐บ๐ธUnited States tedbow Ithaca, NY, USA
Isn't the bigger issue that we are getting untranslated strings from composer stager and we still want to display them to user as translated strings?
Yes this is not ideal but for exceptions from other system we can't do much about that. Using the token in the
t()
function will allow the rest of the message to be translated. Usually these tokens are for smaller things like a username that can't be translated. - Assigned to omkar.podey
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:26am 13 February 2023 - ๐ฎ๐ณIndia omkar.podey
Seems to have tests already so, needs review.
- Assigned to tedbow
- Status changed to RTBC
almost 2 years ago 8:55am 13 February 2023 - ๐บ๐ธUnited States tedbow Ithaca, NY, USA
Merge failed so it merge 8.x-2.x here.
Looks good, will merge when green
-
tedbow โ
committed f984bfe3 on 8.x-2.x
Issue #3339016 by tedbow, omkar.podey, diegors, Wim Leers: "Composer not...
-
tedbow โ
committed f984bfe3 on 8.x-2.x
- Status changed to Fixed
almost 2 years ago 3:55pm 13 February 2023 - ๐บ๐ธUnited States tedbow Ithaca, NY, USA
๐ Thanks @omkar.podey and @Wim Leers!
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.