Claro: Text overlaps the icon in select list on rtl

Created on 23 January 2023, about 2 years ago
Updated 11 July 2023, over 1 year ago

Problem/Motivation

Action select list item overlaps the icon in 'RTL'. Check screenshot

Steps to reproduce

1. Go to admin/content page in RTL direction.
2. Select Remove content from front page
3. You will see the text overlaps the icon.

Proposed resolution

Fix the RTL styling.

🐛 Bug report
Status

Fixed

Version

11.0 🔥

Component
Claro 

Last updated about 3 hours ago

Created by

🇮🇳India gauravvvv Delhi, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @gauravvvv
  • Status changed to Needs review about 2 years ago
  • 🇮🇳India gauravvvv Delhi, India

    I have provided the patch for RTL dir, Please review

  • Status changed to Needs work almost 2 years ago
  • 🇮🇳India sonam.chaturvedi Pune

    Verified and tested patch #2 on 10.1.x-dev. Patch applied successfully.

    Test Steps:
    1. Add an RTL language
    2. Goto /admin/content page
    3. Select "Remove content from front page" option
    4. Verify icon overlaps
    5. Apply patch #2 and check issue is resolved or not

    Test Result: Issue is not resolved after applying patch due to padding added. Option text stills overlaps the icon in RTL.

    Before Patch:

    After Patch:

    Expected:

    Moving to Needs Work.

  • 🇮🇳India gauravvvv Delhi, India

    I think you need to clear your cache, In your second screenshot, I can't see the code from patch

    [dir="rtl"] .views-bulk-actions__item .form-element--type-select {
      padding: calc(0.5rem - 1px) calc(1rem - 1px) calc(0.5rem - 1px) calc(2.25rem - 1px);
    }

    Please see

  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India sonam.chaturvedi Pune

    Thanks @Gauravv. I had cleared the drupal cache, however I think it was still cached.

    Re-tested with new drupal 10.1.x-dev installation. And patch #2 resolves the issue.
    Attaching only after patch screenshot as before patch screenshot is added in #3.

    After patch:

  • Status changed to Needs work almost 2 years ago
  • 🇺🇸United States smustgrave

    We have been removing rtl in the claro refactoring tickets. Should we avoid adding a new instance here?

    Could be wrong.

  • Status changed to Needs review over 1 year ago
  • last update over 1 year ago
    29,804 pass
  • 🇮🇳India gauravvvv Delhi, India

    The refactor issue for tableselect has been marked as closed, allowing us to focus on addressing it within this specific issue. I have included the parent issue for reference.

    I have re-rolled the patch as patch #2 is not applying anymore.

  • Status changed to RTBC over 1 year ago
  • 🇺🇸United States smustgrave

    Confirmed the issue by installing Arabic language.
    Patch #8 resolves the issue

    • lauriii committed 5cc9e951 on 11.x
      Issue #3335670 by Gauravvvv, sonam.chaturvedi, smustgrave: Claro: Text...
    • lauriii committed 36e56d36 on 10.1.x
      Issue #3335670 by Gauravvvv, sonam.chaturvedi, smustgrave: Claro: Text...
  • Status changed to Fixed over 1 year ago
  • 🇫🇮Finland lauriii Finland

    Committed 5cc9e95 and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024