- Issue created by @gauravvvv
- Status changed to Needs review
about 2 years ago 8:22am 23 January 2023 - 🇮🇳India gauravvvv Delhi, India
I have provided the patch for RTL dir, Please review
- Status changed to Needs work
almost 2 years ago 4:32am 24 January 2023 - 🇮🇳India sonam.chaturvedi Pune
Verified and tested patch #2 on 10.1.x-dev. Patch applied successfully.
Test Steps:
1. Add an RTL language
2. Goto /admin/content page
3. Select "Remove content from front page" option
4. Verify icon overlaps
5. Apply patch #2 and check issue is resolved or notTest Result: Issue is not resolved after applying patch due to padding added. Option text stills overlaps the icon in RTL.
Before Patch:
After Patch:
Expected:
Moving to Needs Work.
- 🇮🇳India gauravvvv Delhi, India
I think you need to clear your cache, In your second screenshot, I can't see the code from patch
[dir="rtl"] .views-bulk-actions__item .form-element--type-select { padding: calc(0.5rem - 1px) calc(1rem - 1px) calc(0.5rem - 1px) calc(2.25rem - 1px); }
Please see
- Status changed to Needs review
almost 2 years ago 5:39am 24 January 2023 - 🇮🇳India sonam.chaturvedi Pune
Thanks @Gauravv. I had cleared the drupal cache, however I think it was still cached.
Re-tested with new drupal 10.1.x-dev installation. And patch #2 resolves the issue.
Attaching only after patch screenshot as before patch screenshot is added in #3.After patch:
- Status changed to Needs work
almost 2 years ago 6:52pm 18 February 2023 - 🇺🇸United States smustgrave
We have been removing rtl in the claro refactoring tickets. Should we avoid adding a new instance here?
Could be wrong.
- Status changed to Needs review
over 1 year ago 4:25am 10 July 2023 - last update
over 1 year ago 29,804 pass - 🇮🇳India gauravvvv Delhi, India
The refactor issue for tableselect has been marked as closed, allowing us to focus on addressing it within this specific issue. I have included the parent issue for reference.
I have re-rolled the patch as patch #2 is not applying anymore.
- Status changed to RTBC
over 1 year ago 5:00pm 11 July 2023 - 🇺🇸United States smustgrave
Confirmed the issue by installing Arabic language.
Patch #8 resolves the issue - Status changed to Fixed
over 1 year ago 8:24pm 11 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.