Automated Drupal 10 compatibility fixes

Hello, can this be merged? This is pretty blocking for new websites using Drupal 10.

Howdy,

I was able to install the patched module in Drupal 10.0.8, and can confirm that it works as expected.

It would be nice to have a new release so that it can be installed properly using composer. ;)

Very grateful if a release is available soon....

Very grateful to see progress on this. For my installation with dozens of modules, this is the last one in the Upgrade Status report showing as incompatible with Drupal 10. I'm not going to install on a production service a version that's marked as development-only, so a proper release for a D10-compatible version of this module would be much appreciated. Thanks to the maintainers,

composer failed to apply this patch for me. this is the last module blocking my upgrade.

Patch failed to apply:

 sudo -u www-data patch -p1 < insert_view.3.0.x-dev.rector.patch
patching file insert_view.info.yml
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file insert_view.info.yml.rej

Please review.

I have reviewed and checked MR !5 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:

Can be moved to RTBC+1

This patch fails to apply on 9.5.9

Please do not post screenshots of it passing the Upgrade Module status. It does not help.

It's a very simply patch. I'm not sure why it's not applying.

@nicoleannevella - If the Merge Request is confirmed to work (by @bushra-shaikh) isn't that good enough, ie no need for the patch?

On my system the patch failed because the file has additional packaging info lines as described in this blog post and core issue 3036459 🐛 Packaging info from .info.yml often creates conflicts when patching Active , ie these lines:

# Information added by Drupal.org packaging script on 2022-09-29
version: '2.0.1'
project: 'insert_view'
datestamp: 1664469525

So the patch could be fixed to account for that, but the MR does the same thing so accepting that should do the job.

#2 applies fine to 3.0.x-dev
and resolves the issue.

Will this be released soon for D10? Thank you for everyone's hard work on this.

Echoing on @lebachai's comment. Hope this can be released soon.

Thank you for linking to that Chromatic post @gaddman! I was able to apply the patch in #2 against the stable 2.0.1 version using

        "preferred-install": {
            "drupal/insert_view": "source"

since I strongly prefer not to install a dev version on production. Hopefully a maintainer will merge this MR and release a stable Drupal 10 compatible version soon.

Also hoping to get this merged soon to have a Drupal 10 version.

It doesn’t seem like the maintainers of this project are going to step in and release this patch. Does anyone know if there is a process or someone to contact about this to see if we can get a new, or even just temporary, maintainer in place to perform the release?

I'm offering to help co-maintain this module to get this release out: https://www.drupal.org/project/insert_view/issues/3394696 💬 Offer to help Maintain Active

RobLoach is now a maintainer. Looking forward to seeing the update come through!

Thanks so much! Since the `3.0.x` and `2.0.x` code was the same, I applied the change to both branches, and made the release as 2.1.0 → . Thanks for all the help and testing, all!

@RobLoach thanks for getting this released!

Automatically closed - issue fixed for 2 weeks with no activity.