- @murz opened merge request.
- Status changed to Needs review
almost 2 years ago 9:29am 8 February 2023 - 🇦🇲Armenia murz Yerevan, Armenia
I've reworked the fix for the 10.1.x branch and have extended unit tests to check this for all storage types.
Also, I've simplified function
setUp()
for all storage tests via moving the custom logic directly to the::listAll()
function.Please review.
- @murz opened merge request.
- @murz opened merge request.
- Status changed to RTBC
almost 2 years ago 3:59pm 18 February 2023 - 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Confirmed this issue by placing that code snippet into a random preprocess_html hook.
Confirmed the error
Applied the patch from MR 3417
Issue has been resolvedAlso see this has test coverage too.
Looks good.
- Status changed to Needs work
almost 2 years ago 1:09pm 22 February 2023 - 🇬🇧United Kingdom catch
Overall looks good and removes some workarounds, but one comment on the MR.
- Status changed to Needs review
almost 2 years ago 2:45pm 22 February 2023 - 🇦🇲Armenia murz Yerevan, Armenia
I've fixed this, @catch - please take a look.
- Status changed to RTBC
almost 2 years ago 3:00pm 22 February 2023 - 🇬🇧United Kingdom catch
The tense matching the other comments is fine, don't think we have a strict guideline for inline comments. Back to RTBC.
- Status changed to Needs work
almost 2 years ago 4:01am 31 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I think @andypost's comment is correct, we can remove that write too
- last update
over 1 year ago 29,388 pass - Status changed to Needs review
over 1 year ago 12:44pm 13 May 2023 - Status changed to RTBC
over 1 year ago 3:23pm 13 May 2023 - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail 46:39 44:30 Running- last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,400 pass - last update
over 1 year ago 29,409 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,418 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,420 pass 46:39 45:19 Running- last update
over 1 year ago 29,429 pass - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,436 pass - last update
over 1 year ago 29,436 pass - last update
over 1 year ago 29,436 pass - last update
over 1 year ago 29,441 pass - last update
over 1 year ago 29,441 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,439 pass - last update
over 1 year ago 29,439 pass -
larowlan →
committed b0dc0e49 on 10.1.x
Issue #3325571 by Murz, andypost, smustgrave, catch, larowlan:...
-
larowlan →
committed b0dc0e49 on 10.1.x
-
larowlan →
committed be366aec on 11.x
Issue #3325571 by Murz, andypost, smustgrave, catch, larowlan:...
-
larowlan →
committed be366aec on 11.x
- Status changed to Fixed
over 1 year ago 11:17pm 9 July 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Automatically closed - issue fixed for 2 weeks with no activity.