add a method to NestedArray that does array_walk_recursive but passes the parents to the callback

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

 369 | ERROR | Parameter $array is not described in comment
 372 | ERROR | Doc comment for parameter &$array does not match
     |       | actual variable name $callback

This does not match up with the file in the MR.

Line 369 is:

  /**

Line 372 is:

   * @param array &$array
   *   A reference to the array to operate on.

I was reviewing the code here @joachim and I was able to reproduce the bot error running:
vendor/bin/phpcs -ps --parallel=$(nproc) --standard="core/phpcs.xml.dist" (the same executed by the commit-code-check.sh script)

The error seems confused, but as far as I could see, this was being caused due to the arrayWalkNested documenting an &$array and the function was expecting $array, I'm moving this back NW to see your thoughts here.

Thanks! That's probably it.

This needs tests -- without that missing '&' it wouldn't work at all!

Just added a new test, I've also changed a little bit the code, the new test is now changing the values of a nested array. Moving back to NR

Just FYI ideally even though the title says it all, should add the proposed solution to the issue summary.

But can tell what you are doing here. Changes aren't large.
Test coverage seems good.
Typehinting complete.

Seems like a good addition to have.

       if (is_array($value)) {
         self::arrayWalkNestedRecursive($value, $callback, $current_parents);
+        continue;
       }
-      else {
-        $callback($value, $current_parents);
-      }
+      $callback($value, $current_parents);
     }

Nitpicking, but I preferred this the way I wrote it as an if/else rather than a guard clause.

No problems @joachim! Just made a rollback.

One comment on the MR. Also are there any contrib modules that can use this?

> One comment on the MR. Also are there any contrib modules that can use this?

Yes -- see https://git.drupalcode.org/project/computed_field/-/blob/4.0.x/src/Eleme... for example.

Basically, you need it anywhere where you need to recurse into an arbitrary form array, and the thing you do to each element needs to be aware of the position of the element in the form.

Replied to comment on MR.

All threads appear to have been answered and this already seemed to get several reviews.

Left a comment on the MR.