Replace strpos/substr with str_starts_with() / str_contains() / str_ends_with()

Updated remaining tasks. No other references are found.
I saw that in some previous commits, some preg_match() was switched with str_starts_with(). I didn't check other instances of preg_match() that could be replaces with these new functions.

I decided to check with rector if it could find any more to replace. I applied the rules StrContainsRector, StrStartsWithRector and StrEndsWithRector. It found one additional file to update, which I have pushed a commit for. The change replaces strpos() !== FALSE with str_contains(substr()) which means more function calls, but I think these are more readable than before. Happy to revert if others disagree.

Hey mstrelan,

Thank you for looking into this issue
I don't see a commit pushed to this branch/MR

Ah I forgot to request push access. Have pushed now.

mstrelan → changed the visibility of the branch 11.x to hidden.

Rebased against latest 11.x and also push an 11.x branch to the fork to workaround ci issues with spell check job.

This looks good, it's no longer touching the Doctrine forked code, can't see anything to complain about.

Shorten the title

I also didn't find anything here to prevent this being committed.

Committed d74c1ca and pushed to 11.x and e5ce10b and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.