Allowed formats are in Drupal 10.1 now, add an upgrade path

So lets offer a 3.x branch that has the upgrade path?

Yes, "lets" do that ;)

That was my proposal, the problem is just that we still need 50% of what this module does, I guess it's unlikely at this point that the referenced issue will get into 10.1. So we have a 3.x that makes allowed_formats really a hide_format_explanation.module, and then maybe a 4.x for a future core version that also removes the need for that bit with another upgrade at which point the module is no longer needed.

I agree 3.x with the missing 50% in the core would be good idea

So we have a 3.x that makes allowed_formats really a hide_format_explanation.module, and then maybe a 4.x for a future core version that also removes the need for that bit with another upgrade at which point the module is no longer needed.

This sounds like a good path forward for this module. I just updated a client site to D10 and having two sets of "allowed formats" settings on fields is confusing for site builders. But we still really need the hide tips/guidelines functionality.

I just updated a client site to D10 and having two sets of "allowed formats" settings on fields is confusing for site builders. But we still really need the hide tips/guidelines functionality.

Seems like this functionality should not have rolled out in core without coordinating with this module to provide that new version/upgrade path. Current users of this module are now confused/penalized by having 2 sets of these checkboxes in the UI and existing field config data stored by the contrib module until an upgrade path is figured out. Will keep an eye on this, for sure.

claudiu.cristea → made their first commit to this issue’s fork.

I’m working on this

Ready for review. Also, as per #4, we need a followup in Drupal core to move also the "hide explanations" feature to core.

Ouch, I see now there's ✨ Add an option to 'hide filter tips' on text fields Needs work

Very nice, with tests and everything! ;) This was on my list, but didn't get to it yet. Added some comments.

Hm, just saw now that testing is not enabled for 2.x :( It would be good to see tests here

Tested a bit on our project, seems to work fine. As mentioned, the idea is to commit this to a new 3.x branch.

I’ve tried to contact the maintainers but got no answer so far. To summarize:

• This needs to be merged in a new 3.x branch
• Tests should be enabled for 3.x branch with D10.1
• Cut a 3.0.0 release

This all looks awesome overall.

One question -- is the allowed_formats_field_config_presave really needed? I don't believe that I've seen this pattern before -- even in core data updates. It seems to be pretty widely understood that running database updates is an important step in the CI/CD/manual upgrade process.

Definitely not a blocking review, and can easily be removed in 4.x whenever core adopts the pending widget config settings. I'm more curious from a learner's perspective than anything.

Yes, that is in fact the pattern that core is mostly using, See my review comments which also mention an example.

Ran this update on our project with over 50 formatted text fields and all updated as expected, great work!

Will cut a 3.0.0-alpha1 release to be evaluated by the community

I can confirm the set allowed format (a reduced HTML set) for a text field was properly migrated over after updating to 3.0.0-alpha1 and performing an updb step.
And I can only use the allowed format afterwards.

So it works as it should from my side, thanks!

Updated the agreed upon resolution so it's easier for people to understand how this issue was resolved.

I think the project page needs also an update, same as for the README but I have no permission to do that

3.0.0-alpha1 worked for me and was able to update to Drupal 10.1's built in allowed_formats setting.

I've released 3.0.0 → and added there release notes about this important change. I've also added those explanations to the module's front page https://www.drupal.org/project/allowed_formats →

Automatically closed - issue fixed for 2 weeks with no activity.