Contrib.social

Claro removes contextual links of layout builder symmetric translations

Open on Drupal.org →
Created on 28 November 2022, almost 3 years ago
Updated 4 November 2024, 11 months ago

Problem/Motivation

When you use layout builder symmetric translations then claro theme removes the contextual links and you cannot translate blocks in layout builder. This is because claro only keeps contextual links under layout_builder_block key. But with layout builder symmetric translation the links are stored under layout_builder_block_translation key.

Steps to reproduce

1. Use claro as admin theme
2. Enable layout builder
3. Enable layout builder symmetric translations either by using core patch:
http://www.drupal.org/node/2946333
Or installing layout_builder_st → module
4. Enable module layout_builder_admin_theme → so claro can be used as admin theme when editing layouts
5. Add secondary language
6. Create content, add custom block in layout builder
7. Translate the content into secondary language
8. Go to layout edit page of the translated node. The contextual links are missing as they are removed by claro theme

Proposed resolution

Claro should not remove contextual links.

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
Claro  →

Last updated about 1 month ago

Created by

🇸🇰Slovakia hideaway

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Can we get a test case to show this scenario please

    Did not test

  • First commit to issue fork.
  • Merge request !10047Patch for contextual links removal → (Open) created by arunkumark
  • Pipeline finished with Success
    11 months ago
    #328792
  • Comment 11 months ago →
    🇮🇳India arunkumark Coimbatore

    Created MR for the patch #3. Not sure do we need a test case for the additional contrib module. Already there is a check for the title suffix and contextual link in /core/tests/Drupal/FunctionalTests/Theme/ClaroLayoutBuilderTest.php

  • Comment 11 months ago →
    🇺🇸United States smustgrave

    Change still needs test coverage.

  • Pipeline finished with Failed
    1 day ago
    #617359
  • Pipeline finished with Running
    1 day ago
    #617417
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024