πŸ‡ΈπŸ‡°Slovakia @hideaway

Account created on 5 March 2010, over 14 years ago
#

Recent comments

πŸ‡ΈπŸ‡°Slovakia hideaway

Forgotten patch file :)

πŸ‡ΈπŸ‡°Slovakia hideaway

There is a problem with the patch when prefix is an array and results into an error when logging messages. Correct version in the last else statement should be '@prefix' => $p:

else {
  foreach ($prefix as $p) {
    $keys = $redis->keys('*' . $p . '*');
    $redis->del($keys);
    Drupal::logger('redis')->info(t('Redis Keys deleted for prefix @prefix', ['@prefix' => $p]));
    Drupal::messenger()->addMessage(t('Redis Keys deleted for prefix @prefix', ['@prefix' => $p]));
  }
}

As we don't use MR diff or patch files in our builds as they are dangerous, attaching a patch file to have working static patch.

πŸ‡ΈπŸ‡°Slovakia hideaway

@Grevil something went wrong with your MR. First of all it broke our builds as latest version does not apply to latest D10. And secondly, if you try to access patch file via url https://git.drupalcode.org/project/drupal/-/merge_requests/2807.patch you'll see its file size is 105MB:

$ wget https://git.drupalcode.org/project/drupal/-/merge_requests/2807.patch -O /tmp/2807.patch
$ ls -lash /tmp/2807.patch 
105M -rw-rw-r-- 1 hideaway hideaway 105M May 20 11:21 /tmp/2807.patch
πŸ‡ΈπŸ‡°Slovakia hideaway

This should be fixed in 1.0.1 as I immediately spotted it too after initial release. Are you sure you did use v1.0.1?

πŸ‡ΈπŸ‡°Slovakia hideaway

I needed a patch file which applies cleanly when packaging info is added to the info.yml file of the module, so uploading it here

πŸ‡ΈπŸ‡°Slovakia hideaway

The following patch should do the trick.

Production build 0.69.0 2024