Use ApiRequestTrait in \Drupal\Tests\rest\Functional\ResourceTestBase

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
🇫🇷France vbouchet
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Status changed to Needs work 8 months ago6:12pm 31 October 2023
Comment 8 months ago →
🇺🇸United States smustgrave
Think it's a CC failure? Though updated deps is new to me.

Maybe turn to an MR to be sure?

Change looks fine though. Just optimizing existing code.
Comment 8 months ago →
🇫🇷France vbouchet
As you mentioned in other issue, seems the tests are not executed automatically anymore. At least I had to manually queues these for the few patches I submited today and I also noticed the "reqs" things. I will try to turn it into a MR layer.
@vbouchet opened merge request.
Status changed to Needs review 8 months ago1:15pm 9 November 2023
Comment 8 months ago →
🇫🇷France vbouchet
I applied the same change in a MR instead of a patch.
Status changed to RTBC 8 months ago8:04pm 9 November 2023
Comment 8 months ago →
🇺🇸United States smustgrave
Reran nightwatch and it was a random failure.

Change looks good!
Status changed to Needs work 8 months ago11:57am 11 November 2023
Comment 8 months ago →
🇬🇧United Kingdom longwave UK
I think this should also try to replace ResourceTestBase::request() with ApiRequestTrait::makeApiRequest() as the code looks pretty similar.

Comments & Activities