- 🇮🇳India himanshu_jhaloya Indore
After applying the patch still facing some Coding standard issues created a new patch to improve the code base
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 10:14am 2 February 2023 - 🇮🇳India Sonal Gyanani
After applying patch #9 still shows following errors
FILE: ...htdocs\drupalissues-9.5.x-dev\modules\jcarousel\jcarousel.module ---------------------------------------------------------------------- FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 10 LINES ---------------------------------------------------------------------- 13 | WARNING | Global constants should not be used, move it to a | | class or interface 74 | ERROR | Doc comment is empty 140 | ERROR | Doc comment is empty 231 | ERROR | Doc comment is empty 324 | ERROR | Doc comment is empty 461 | ERROR | Type hint "array" missing for $images 461 | ERROR | Type hint "array" missing for $options 504 | ERROR | The text '@deprecated Please use render arrays with | | element theme 'jcarousel' instead.' does not match | | the standard format: @deprecated in | | %deprecation-version% and is removed from | | %removal-version%. %extra-info%. 505 | WARNING | The @see url 'jcarousel_theme()' does not match the | | standard: http(s)://www.drupal.org/node/n or | | http(s)://www.drupal.org/project/aaa/issues/n 507 | ERROR | Type hint "array" missing for $options 647 | ERROR | Type hint "array" missing for $items 647 | ERROR | Type hint "array" missing for $options ----------------------------------------------------------------------
Moving it to Needs work
- 🇮🇳India Akram Khan Cuttack, Odisha
added updated patch fixed all coding standard issues those are remaining that are not fixable
- Assigned to elber
- Status changed to Needs review
almost 2 years ago 11:00am 14 February 2023 - Issue was unassigned.
- 🇧🇷Brazil elber Brazil
Hi I did a reroll and fixed the phpcs errors please revise.
- First commit to issue fork.
- 🇧🇷Brazil lucienchalom
I fixed some more CS problems, the unused variables and the "global constant should not be used"
- Assigned to elber
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 12:48pm 15 February 2023 - 🇧🇷Brazil elber Brazil
HI moving to RTBC:
Module keeps working as expected
Phpcs errors was fixed.Just this errors are remaining:
FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------- 236 | ERROR | Style definitions must end with a semicolon 262 | ERROR | Style definitions must end with a semicolon ---------------------------------------------------------------------------------------------------------------------------------- FILE: /home/elber/Documentos/Environments/Drupal10/drupal-10.1.x-dev/modules/contrib/jcarousel/skins/tango/jcarousel-tango.css ------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------ 254 | ERROR | Style definitions must end with a semicolon 281 | ERROR | Style definitions must end with a semicolon -----------------------------------------------------------------------------
But I think these errors very hard to fix and you should open another issue to fix it.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.
- Status changed to Needs work
over 1 year ago 11:47am 13 May 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:54pm 15 June 2023 - Status changed to RTBC
over 1 year ago 6:56pm 15 June 2023 - 🇧🇷Brazil lucienchalom
folowing the issue sumary, the only problems remaining were cited in #7 and #19.
The MR is still okay and no new coding standard were added.
moving to RTBC - Status changed to Needs work
over 1 year ago 12:37pm 16 June 2023 - Status changed to Needs review
over 1 year ago 11:46am 19 June 2023 - 🇧🇷Brazil lucienchalom
Added back the deprecation tag, the See tag after it will report a problem, because there is no link apropriated to it. The function was deprecated ouside a Drupal.org issue:
original commitI also separate the upercase and lowercase fixes in a diferent commit, and tried to fix the most of the inconsistencies.
I hope its better now.
Please review - Status changed to RTBC
9 months ago 2:52pm 24 April 2024 - 🇮🇳India jaydev bhatt Pune, Maharashtra
Reviewed/ Verified the merge request and found no new PHPCS errors. Moving this issue to RTBC status.
- Status changed to Needs review
9 months ago 10:59am 1 May 2024