Fix migrate destination entity PHPStan L0 issues

For the change record

Rerolled 3318888-16.patch on 11.x in MR

Added draft CR, definitly needs some eyes on that one.

CR looks good to me, especially since there is nothing for contrib to update.

+   * This method should be implemented in extending classes.

This is the definition of an abstract method, so there is probably no need to explicitly say it.

+   * @throws \LogicException
+   *   Thrown for config entities, if the destination is for translations and
+   *   either the "property" or "translation" property does not exist.

This is describing implementation details, which don't relate to this specific base class.

However, I don't think either of these should hold up commit, so let's just get this in. Committed and pushed 62d7c46774 to 11.x (10.2.x), and published the change record. Thanks!

This is describing implementation details, which don't relate to this specific base class.

Fully agreed, but couldn't see how to address #12.4 and #22.1

Spokje → closed merge request !4249

quietone → credited tstoeckler → .

Closed 📌 \Drupal\migrate\Plugin\migrate\destination\Entity calls methods that are not required by subclasses Closed: duplicate as a duplicate, adding credit.

Automatically closed - issue fixed for 2 weeks with no activity.