Service collector won't collect child services

See that 2 tests were added so would expect both to fail but testProcessChildDefinitionParentInterfaceMismatch passes the test-only feature.

the ::testProcessChildDefinitionParentInterfaceMismatch method is supposed to pass even without the changes

Then why add it? If it's not testing anything new? Expanding test coverage may be considered out of scope.

I just removed additional test

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

False positive

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Left some comments on the MR.

Believe all feedback has been addressed

Ran test-only job here https://git.drupalcode.org/issue/drupal-3309334/-/jobs/5610629 which resulted in

1) Drupal\Tests\Core\DependencyInjection\Compiler\TaggedHandlersPassTest::testProcessChildDefinition
Symfony\Component\DependencyInjection\Exception\LogicException: Service 'child_handler' for consumer 'consumer_id' does not implement Drupal\Tests\Core\DependencyInjection\Compiler\HandlerInterface.
/builds/issue/drupal-3309334/core/lib/Drupal/Core/DependencyInjection/Compiler/TaggedHandlersPass.php:182
/builds/issue/drupal-3309334/core/lib/Drupal/Core/DependencyInjection/Compiler/TaggedHandlersPass.php:116
/builds/issue/drupal-3309334/core/tests/Drupal/Tests/Core/DependencyInjection/Compiler/TaggedHandlersPassTest.php:329
ERRORS!

Committed/pushed to 11.x - I think we need to allow contrib modules to have the same definition between 11.x and 10.x so also cherry-picked to 10.6.x, thanks!

catch → closed merge request !2756